<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git, branch th/module-close</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>device: don't unload settings plugins on failure</title>
<updated>2016-04-29T13:28:04+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-04-29T13:00:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=726f830c107fe57a05accd173658d56b4788ed19'/>
<id>726f830c107fe57a05accd173658d56b4788ed19</id>
<content type='text'>
Also, registering a weak-pointer to close the module that
was just made as resident is pointless.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also, registering a weak-pointer to close the module that
was just made as resident is pointless.
</pre>
</div>
</content>
</entry>
<entry>
<title>device: don't unload device plugins on failure</title>
<updated>2016-04-29T13:28:04+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-04-29T13:00:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=726bb0f6bab49c5b5a27857063c4e2939f9c73ae'/>
<id>726bb0f6bab49c5b5a27857063c4e2939f9c73ae</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm/vpn: don't close the VPN plugin library on cleanup</title>
<updated>2016-04-29T13:28:04+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-04-29T12:55:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=68ce45fe8ce6a19f58934a5e4678dd9ae733cfbb'/>
<id>68ce45fe8ce6a19f58934a5e4678dd9ae733cfbb</id>
<content type='text'>
Closing the library will interfere badly as the glib types cannot be
unregistered. We must leak the library handle.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closing the library will interfere badly as the glib types cannot be
unregistered. We must leak the library handle.
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm/vpn: fix checking service name in nm_vpn_plugin_info_new_search_file()</title>
<updated>2016-04-29T13:28:04+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-04-25T09:21:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=b52485b34b0d94e97a4d64a71a4448378eb43053'/>
<id>b52485b34b0d94e97a4d64a71a4448378eb43053</id>
<content type='text'>
Fixes: 3adf782ab556e343a34f0153f50f72a2fd0ee791
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes: 3adf782ab556e343a34f0153f50f72a2fd0ee791
</pre>
</div>
</content>
</entry>
<entry>
<title>systemd: fix conversion from size_t on s390</title>
<updated>2016-04-29T10:47:34+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2016-04-29T09:25:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=eafa6f725b8aba51984d015246bd74888afbf56d'/>
<id>eafa6f725b8aba51984d015246bd74888afbf56d</id>
<content type='text'>
On s390 size_t is an unsigned long, not an unsigned int. They both are
of the same size and can be cast to each other safely, but the compiler
still seems unhappy about incompatible pointers.

https://github.com/systemd/systemd/pull/3147
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On s390 size_t is an unsigned long, not an unsigned int. They both are
of the same size and can be cast to each other safely, but the compiler
still seems unhappy about incompatible pointers.

https://github.com/systemd/systemd/pull/3147
</pre>
</div>
</content>
</entry>
<entry>
<title>ifupdown: avoid calloc()</title>
<updated>2016-04-29T10:47:34+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2016-04-28T15:48:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=76844c65d6c8ffb5a5b8f5ede3fceada7de9a5da'/>
<id>76844c65d6c8ffb5a5b8f5ede3fceada7de9a5da</id>
<content type='text'>
It can return NULL and makes Coverity upset:

CID 75369 (#1 of 1): Dereference null return value (NULL_RETURNS)
4.  dereference: Dereferencing a null pointer ret.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It can return NULL and makes Coverity upset:

CID 75369 (#1 of 1): Dereference null return value (NULL_RETURNS)
4.  dereference: Dereferencing a null pointer ret.
</pre>
</div>
</content>
</entry>
<entry>
<title>ifnet: fix error handling</title>
<updated>2016-04-29T10:47:34+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2016-04-28T15:39:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=2e563d9c842cda076413c62fe9cd96c58705ea47'/>
<id>2e563d9c842cda076413c62fe9cd96c58705ea47</id>
<content type='text'>
CID 76722 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement:
g_set_error(error, nm_setti....
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
CID 76722 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement:
g_set_error(error, nm_setti....
</pre>
</div>
</content>
</entry>
<entry>
<title>config: call va_end() in unexpected code path too</title>
<updated>2016-04-29T10:47:34+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2016-04-28T15:36:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=dc9bba9e518a34b00a4be94725ce34b63bde989c'/>
<id>dc9bba9e518a34b00a4be94725ce34b63bde989c</id>
<content type='text'>
CID 99747 (#1 of 1): Missing varargs init or cleanup (VARARGS)
13.  missing_va_end: va_end was not called for ap.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
CID 99747 (#1 of 1): Missing varargs init or cleanup (VARARGS)
13.  missing_va_end: va_end was not called for ap.
</pre>
</div>
</content>
</entry>
<entry>
<title>cli: handle device failure when activating</title>
<updated>2016-04-29T09:16:30+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2016-04-01T15:10:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=a06487a6ae5aac42ce1849dc891fc20020168a11'/>
<id>a06487a6ae5aac42ce1849dc891fc20020168a11</id>
<content type='text'>
We might receive the update of the device state to FAILED when the
active connection is still in ACTIVATING. Handle this case properly.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We might receive the update of the device state to FAILED when the
active connection is still in ACTIVATING. Handle this case properly.
</pre>
</div>
</content>
</entry>
<entry>
<title>build: cleanup include of &lt;config.h&gt;</title>
<updated>2016-04-28T17:02:58+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-04-28T16:58:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=f027b71f6597f5081c87b70e044a4d0c4202766d'/>
<id>f027b71f6597f5081c87b70e044a4d0c4202766d</id>
<content type='text'>
It is recomended to include &lt;config.h&gt; with angle brackets [1].

Note, that usually we don't include &lt;config.h&gt; directly, except in
two places we have to (because there we include conflicting libraries
that must be included before "nm-default.h").
In that case, define __CONFIG_H__ which is used as include guard around
&lt;config.h&gt; by "nm-default.h".

[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Configuration-Headers.html
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It is recomended to include &lt;config.h&gt; with angle brackets [1].

Note, that usually we don't include &lt;config.h&gt; directly, except in
two places we have to (because there we include conflicting libraries
that must be included before "nm-default.h").
In that case, define __CONFIG_H__ which is used as include guard around
&lt;config.h&gt; by "nm-default.h".

[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Configuration-Headers.html
</pre>
</div>
</content>
</entry>
</feed>
