<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git, branch th/logging-inline-enabled</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>logging: make nm_logging_enabled() inline function</title>
<updated>2016-05-19T17:51:31+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T17:05:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=6dfad411ca7e2326b7b169c3635eff67c83bed1b'/>
<id>6dfad411ca7e2326b7b169c3635eff67c83bed1b</id>
<content type='text'>
Basically every logging statement is wrapped by a nm_logging_enabled()
to evaluate the function call of the logging lazy.

Make the function a candidate for inlining, it safes some space. On
a default build it goes for me from 2580584 to 2560104 bytes (20k).

   $ ./autogen.sh &amp;&amp; make &amp;&amp; strip ./src/NetworkManager
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Basically every logging statement is wrapped by a nm_logging_enabled()
to evaluate the function call of the logging lazy.

Make the function a candidate for inlining, it safes some space. On
a default build it goes for me from 2580584 to 2560104 bytes (20k).

   $ ./autogen.sh &amp;&amp; make &amp;&amp; strip ./src/NetworkManager
</pre>
</div>
</content>
</entry>
<entry>
<title>logging: move static variable with logging state to file-scope</title>
<updated>2016-05-19T17:51:31+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T17:01:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=32133a0c51041ed8245291bd2fb10975649e416a'/>
<id>32133a0c51041ed8245291bd2fb10975649e416a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>logging: remove assertion in nm_logging_enabled() from production builds</title>
<updated>2016-05-19T17:51:31+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T16:58:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=8b4155e9603f232c21a7d359eea603682460be04'/>
<id>8b4155e9603f232c21a7d359eea603682460be04</id>
<content type='text'>
We really expect this assertion not to be violoated.

As we want for nm_logging_enabled() to become smaller and inline,
remove the runtime assertion from regular builds.

Live fast and dangerous.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We really expect this assertion not to be violoated.

As we want for nm_logging_enabled() to become smaller and inline,
remove the runtime assertion from regular builds.

Live fast and dangerous.
</pre>
</div>
</content>
</entry>
<entry>
<title>logging: drop explicit initialization of nm-logging</title>
<updated>2016-05-19T17:51:31+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T16:57:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=a4567f08b8a9a02cbb272acb8d78898eb1855a64'/>
<id>a4567f08b8a9a02cbb272acb8d78898eb1855a64</id>
<content type='text'>
Instead of calling _ensure_initialized() at various places
to ensure that we setup logging before any logging commands
are executed, initialize the logging fields in the global variable.

This removes code from nm_logging_enabled(), which we want to
become a static inline function.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of calling _ensure_initialized() at various places
to ensure that we setup logging before any logging commands
are executed, initialize the logging fields in the global variable.

This removes code from nm_logging_enabled(), which we want to
become a static inline function.
</pre>
</div>
</content>
</entry>
<entry>
<title>config: add file name to error messages for parsing failures</title>
<updated>2016-05-19T16:12:06+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2016-05-19T15:52:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=57c001200db44ef7077381d10f3c12f6a64e3690'/>
<id>57c001200db44ef7077381d10f3c12f6a64e3690</id>
<content type='text'>
When one of the configuration snippet is malformed, NM doesn't tell
which file caused the error:

$ NetworkManager --print-config
Failed to read configuration: Key file does not start with a group

Fix this.

$ NetworkManager --print-config
Failed to read configuration: /usr/lib/NetworkManager/conf.d/test.conf: Key file does not start with a group
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When one of the configuration snippet is malformed, NM doesn't tell
which file caused the error:

$ NetworkManager --print-config
Failed to read configuration: Key file does not start with a group

Fix this.

$ NetworkManager --print-config
Failed to read configuration: /usr/lib/NetworkManager/conf.d/test.conf: Key file does not start with a group
</pre>
</div>
</content>
</entry>
<entry>
<title>cli: re-merge branch 'th/cli-vpn-import-fixes-rh1337300'</title>
<updated>2016-05-19T15:21:44+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T10:56:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=77e7a9c0759fabbd0f86ac663169bab36d04f56a'/>
<id>77e7a9c0759fabbd0f86ac663169bab36d04f56a</id>
<content type='text'>
(fix wrong merge. I already cherry-picked 3d25b2e to nm-1-2)

https://bugzilla.redhat.com/show_bug.cgi?id=1337300
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(fix wrong merge. I already cherry-picked 3d25b2e to nm-1-2)

https://bugzilla.redhat.com/show_bug.cgi?id=1337300
</pre>
</div>
</content>
</entry>
<entry>
<title>cli: remove wrong assertion in check_valid_name()</title>
<updated>2016-05-19T15:09:06+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2016-05-19T13:01:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=73221a809d80799c09b2c97fd821e362acce75c3'/>
<id>73221a809d80799c09b2c97fd821e362acce75c3</id>
<content type='text'>
As explained in the function comment, a NULL value for @val is
acceptable. Otherwise:

$ nmcli connection edit
 (process:2276): nmcli-CRITICAL **: check_valid_name: assertion 'val' failed

Fixes: fb8fe1d8cb452d203c8cf0941c2a82e5903a0c8a
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As explained in the function comment, a NULL value for @val is
acceptable. Otherwise:

$ nmcli connection edit
 (process:2276): nmcli-CRITICAL **: check_valid_name: assertion 'val' failed

Fixes: fb8fe1d8cb452d203c8cf0941c2a82e5903a0c8a
</pre>
</div>
</content>
</entry>
<entry>
<title>cli: merge branch 'th/cli-vpn-import-fixes-rh1337300'</title>
<updated>2016-05-19T10:56:47+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T10:56:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=3d25b2e1a1eb4377d202055e901b51bfb0415f56'/>
<id>3d25b2e1a1eb4377d202055e901b51bfb0415f56</id>
<content type='text'>
https://bugzilla.redhat.com/show_bug.cgi?id=1337300
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.redhat.com/show_bug.cgi?id=1337300
</pre>
</div>
</content>
</entry>
<entry>
<title>clients,cli: show better error message when failing to load VPN plugin</title>
<updated>2016-05-19T10:52:59+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T09:17:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=d0f01aa2c26f7a3e34d80477ccc4989b1571a6d4'/>
<id>d0f01aa2c26f7a3e34d80477ccc4989b1571a6d4</id>
<content type='text'>
VPN plugins are often not installed or they might be legacy-only.
In both cases we should show a better error message about the
failure reason.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
VPN plugins are often not installed or they might be legacy-only.
In both cases we should show a better error message about the
failure reason.
</pre>
</div>
</content>
</entry>
<entry>
<title>clients,cli: for connection-add consider VPNs as loaded from the plugin</title>
<updated>2016-05-19T10:52:59+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2016-05-19T08:51:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=41976e30690d36cc3998c5025ac70c8cbaa8f897'/>
<id>41976e30690d36cc3998c5025ac70c8cbaa8f897</id>
<content type='text'>
Instead of using (only) a hard-coded list of VPN types,
prefer lookup the VPN settings from the .name files.

Still, fallback to a hard-coded list if the plugin cannot
be found, because for connection-add we currently don't
actually need the plugin installed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of using (only) a hard-coded list of VPN types,
prefer lookup the VPN settings from the .name files.

Still, fallback to a hard-coded list if the plugin cannot
be found, because for connection-add we currently don't
actually need the plugin installed.
</pre>
</div>
</content>
</entry>
</feed>
