<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git, branch th/device-reapply-metric</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>device: avoid accidentally changing route-metric during config-reload</title>
<updated>2018-06-14T10:30:28+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T09:43:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=2f0d26e02cfc20c1a6423c3c611062c3d9418621'/>
<id>2f0d26e02cfc20c1a6423c3c611062c3d9418621</id>
<content type='text'>
It's not properly implemented, to change the route-metric while
being active. That would require pecular re-initializations.

Avoid that a configuration reload, can change the used route-metric
unexpectedly.

It doesn't cover all potential changes, because
nm_manager_device_route_metric_reserve() might still return a different
value. That is however rather unlikely, because neither the ifindex nor
the device-type is expected to change.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's not properly implemented, to change the route-metric while
being active. That would require pecular re-initializations.

Avoid that a configuration reload, can change the used route-metric
unexpectedly.

It doesn't cover all potential changes, because
nm_manager_device_route_metric_reserve() might still return a different
value. That is however rather unlikely, because neither the ifindex nor
the device-type is expected to change.
</pre>
</div>
</content>
</entry>
<entry>
<title>device: cache the NMConfigData instance for the current activation</title>
<updated>2018-06-14T10:30:28+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T09:24:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e4426e302a6890cc2588d59eeea542cf0ad971d5'/>
<id>e4426e302a6890cc2588d59eeea542cf0ad971d5</id>
<content type='text'>
NMConfig has pointers to current NMConfigData. The NMConfigData itself
is immutable, during config-reload, NMConfig will switch the instance
to a new config-data. This conveniently allows to take a snapshot
of a particular configuration.

Cache such an instance in the NMDevice, and initialize it, when
activation begins.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
NMConfig has pointers to current NMConfigData. The NMConfigData itself
is immutable, during config-reload, NMConfig will switch the instance
to a new config-data. This conveniently allows to take a snapshot
of a particular configuration.

Cache such an instance in the NMDevice, and initialize it, when
activation begins.
</pre>
</div>
</content>
</entry>
<entry>
<title>device: don't allow reapplying a different route-metric</title>
<updated>2018-06-14T09:39:06+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T09:19:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=0a018a961fb1fc8d32b6d2a8b148e359249915e2'/>
<id>0a018a961fb1fc8d32b6d2a8b148e359249915e2</id>
<content type='text'>
It's complicated to handle, and currently not handled properly.
Don't allow it, and fail.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's complicated to handle, and currently not handled properly.
Don't allow it, and fail.
</pre>
</div>
</content>
</entry>
<entry>
<title>device: simplify nm_device_hash_check_invalid_keys()</title>
<updated>2018-06-14T09:39:06+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T09:02:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=2dacbd08b4119288fcd376ea5bb314a8fced1274'/>
<id>2dacbd08b4119288fcd376ea5bb314a8fced1274</id>
<content type='text'>
Rather trivial change. Return-early, to completely handle the simpler
case (the success case) first. In the failure case, we only need
extra effort to generate a nice error message.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Rather trivial change. Return-early, to completely handle the simpler
case (the success case) first. In the failure case, we only need
extra effort to generate a nice error message.
</pre>
</div>
</content>
</entry>
<entry>
<title>core/trivial: rename local variables to make code clearer</title>
<updated>2018-06-14T09:39:06+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T08:58:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=8a6c0467ea1a3375c8cc05bbae522f85188baa32'/>
<id>8a6c0467ea1a3375c8cc05bbae522f85188baa32</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>device: check for proxy setting separately in can_reapply_change()</title>
<updated>2018-06-14T09:39:06+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T08:39:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=37b10e8f73891bf747bb9dac0f6a4cea0cb02b92'/>
<id>37b10e8f73891bf747bb9dac0f6a4cea0cb02b92</id>
<content type='text'>
Proxy setting has not property NM_SETTING_IP_CONFIG_ROUTE_TABLE.
It's odd to handle it in the same if-block as IP configs.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Proxy setting has not property NM_SETTING_IP_CONFIG_ROUTE_TABLE.
It's odd to handle it in the same if-block as IP configs.
</pre>
</div>
</content>
</entry>
<entry>
<title>shared: simplify nm_g_object_ref_set()</title>
<updated>2018-06-14T09:39:06+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T09:32:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=15188f5748165adca5489432a27b2a1cc6966a22'/>
<id>15188f5748165adca5489432a27b2a1cc6966a22</id>
<content type='text'>
Also, assign *_pp before unref-ing the old value. Calling
g_object_unref() on the old value, might invoke some callbacks
which are out of the contorl of nm_g_object_ref_set(). During
that time, the pointer should already be assigned the new value,
instead of having an intermediate %NULL value.

Also, don't use typeof(**_pp), which would not work with opaque
types (that we commonly have).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also, assign *_pp before unref-ing the old value. Calling
g_object_unref() on the old value, might invoke some callbacks
which are out of the contorl of nm_g_object_ref_set(). During
that time, the pointer should already be assigned the new value,
instead of having an intermediate %NULL value.

Also, don't use typeof(**_pp), which would not work with opaque
types (that we commonly have).
</pre>
</div>
</content>
</entry>
<entry>
<title>device: fix crash during reapply</title>
<updated>2018-06-14T09:34:26+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-06-14T08:41:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=53943faa33a35031fda163a89938522240888341'/>
<id>53943faa33a35031fda163a89938522240888341</id>
<content type='text'>
Fixes: bf3b3d444c7750a68a0771d99f48e663815e258e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes: bf3b3d444c7750a68a0771d99f48e663815e258e
</pre>
</div>
</content>
</entry>
<entry>
<title>merge: branch 'lr/wwan-ppp-route-rh1585611'</title>
<updated>2018-06-14T08:28:00+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2018-06-14T08:28:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=6373196ffdd4133f18c85d9abef6ca9231c49038'/>
<id>6373196ffdd4133f18c85d9abef6ca9231c49038</id>
<content type='text'>
https://github.com/NetworkManager/NetworkManager/pull/132
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://github.com/NetworkManager/NetworkManager/pull/132
</pre>
</div>
</content>
</entry>
<entry>
<title>wwan: ensure the route parameters are set on IPv6 only configuration</title>
<updated>2018-06-13T14:56:51+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2018-06-11T10:58:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=650b5fd99e31f9fed74f0600f9613883d3c547ed'/>
<id>650b5fd99e31f9fed74f0600f9613883d3c547ed</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
