<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git, branch th/device-availability</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>core: ignore unmanaged devices for explicit activation request with multi-connect</title>
<updated>2018-10-17T10:36:43+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-10-17T09:33:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e86e73dd961959060503530d8b847eb8df7b2b2e'/>
<id>e86e73dd961959060503530d8b847eb8df7b2b2e</id>
<content type='text'>
When a device is unmanaged, an explicit activation request can
still activate it.

In particular, that is the case for

  nmcli connection up "$PROFILE" ifname "$DEVICE"

It is also the case, for

  nmcli connection up "$PROFILE"

alone, where NetworkManager searches for a suitable device.

Previously, that would also always consider unmanaged devices
as suitable candidates. I think that makes sense, as usually
a profile is strictly tied to a device via matches like
"connection.interface-name".

However, for profiles with "connection.multi-connect" not "single",
it seems this behavior is not best. Here, the profile is commonly
not tied to one device, but multiple. So, we probably should not
consider unmanaged devices as suitable candidates.

Change the behavior for such profiles. Note, that now the behavior
differs depending on "connection.multi-connect", which can be seen as
inconsistancy. I think it is preferable, because exactly a
multi-connect "single" profile indeed should be tied to one device.
Which is for example what `nmcli connection add` suggest, by requiring
an "ifname" argument. If the profile is tied to a device, the user's
intent is clear and it should not require an explict

  nmcli device set "$DEVICE" managed yes

call first.

https://bugzilla.redhat.com/show_bug.cgi?id=1639254
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a device is unmanaged, an explicit activation request can
still activate it.

In particular, that is the case for

  nmcli connection up "$PROFILE" ifname "$DEVICE"

It is also the case, for

  nmcli connection up "$PROFILE"

alone, where NetworkManager searches for a suitable device.

Previously, that would also always consider unmanaged devices
as suitable candidates. I think that makes sense, as usually
a profile is strictly tied to a device via matches like
"connection.interface-name".

However, for profiles with "connection.multi-connect" not "single",
it seems this behavior is not best. Here, the profile is commonly
not tied to one device, but multiple. So, we probably should not
consider unmanaged devices as suitable candidates.

Change the behavior for such profiles. Note, that now the behavior
differs depending on "connection.multi-connect", which can be seen as
inconsistancy. I think it is preferable, because exactly a
multi-connect "single" profile indeed should be tied to one device.
Which is for example what `nmcli connection add` suggest, by requiring
an "ifname" argument. If the profile is tied to a device, the user's
intent is clear and it should not require an explict

  nmcli device set "$DEVICE" managed yes

call first.

https://bugzilla.redhat.com/show_bug.cgi?id=1639254
</pre>
</div>
</content>
</entry>
<entry>
<title>device: add and use overrule-unmanaged flag for nm_device_check_connection_available()</title>
<updated>2018-10-17T10:36:43+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-10-17T10:26:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=12bf77685b1c4550cf7e6ea10a947694efc1e5d7'/>
<id>12bf77685b1c4550cf7e6ea10a947694efc1e5d7</id>
<content type='text'>
This flag is more granular in whether to consider the connection
available or not. We probably should never check for the combined
flag NM_DEVICE_CHECK_CON_AVAILABLE_FOR_USER_REQUEST directly, but
always explicitly for the relevant parts.

Also, improve the error message, to indicate whether the device is
strictly unmanaged or whether it could be overruled.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This flag is more granular in whether to consider the connection
available or not. We probably should never check for the combined
flag NM_DEVICE_CHECK_CON_AVAILABLE_FOR_USER_REQUEST directly, but
always explicitly for the relevant parts.

Also, improve the error message, to indicate whether the device is
strictly unmanaged or whether it could be overruled.
</pre>
</div>
</content>
</entry>
<entry>
<title>device: cleanup checking device avilability for ignoring carrier</title>
<updated>2018-10-17T10:23:34+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-10-17T10:02:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=71da14441cffe2df3beb3d058621cab2004d6da4'/>
<id>71da14441cffe2df3beb3d058621cab2004d6da4</id>
<content type='text'>
The flags NMDeviceCheckConAvailableFlags and NMDeviceCheckDevAvailableFlags
both control whether a device appears available (either, available in
general, or related to a particular profile).

Also, both flag types strictly increase availability. Meaning: more flags,
more available.

There is some overlap between the flags, however they still have
their own distinct parts.

Improve the mapping from NMDeviceCheckConAvailableFlags to
NMDeviceCheckDevAvailableFlags, by picking exactly the flags
that are relevant.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The flags NMDeviceCheckConAvailableFlags and NMDeviceCheckDevAvailableFlags
both control whether a device appears available (either, available in
general, or related to a particular profile).

Also, both flag types strictly increase availability. Meaning: more flags,
more available.

There is some overlap between the flags, however they still have
their own distinct parts.

Improve the mapping from NMDeviceCheckConAvailableFlags to
NMDeviceCheckDevAvailableFlags, by picking exactly the flags
that are relevant.
</pre>
</div>
</content>
</entry>
<entry>
<title>core/trivial: add code comment for NMDeviceCheckDevAvailableFlags and NMDeviceCheckConAvailableFlags</title>
<updated>2018-10-17T10:23:06+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-10-17T10:13:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=b1065a67e4a4a0742f59a1105ea016155a9dd34f'/>
<id>b1065a67e4a4a0742f59a1105ea016155a9dd34f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>core/trivial: add code comment for nm_manager_get_best_device_for_connection()</title>
<updated>2018-10-17T10:22:53+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-10-17T10:21:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=5e1db692a64a1b4c5f9786e0c47eb5308d3a7bb9'/>
<id>5e1db692a64a1b4c5f9786e0c47eb5308d3a7bb9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>core: fix checking multi-connect flag in nm_manager_get_best_device_for_connection()</title>
<updated>2018-10-17T10:22:14+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-10-17T10:21:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=292efba9d7c6986b533473a155c767deddd81a8b'/>
<id>292efba9d7c6986b533473a155c767deddd81a8b</id>
<content type='text'>
We should not check @sett_conn, but @connection.

Fixes: 09719bc479b63c8e5fef3950e980b263aca7eff5
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should not check @sett_conn, but @connection.

Fixes: 09719bc479b63c8e5fef3950e980b263aca7eff5
</pre>
</div>
</content>
</entry>
<entry>
<title>core: improve selection of device when activating profile on any device</title>
<updated>2018-10-17T09:10:31+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2018-10-15T13:23:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=09719bc479b63c8e5fef3950e980b263aca7eff5'/>
<id>09719bc479b63c8e5fef3950e980b263aca7eff5</id>
<content type='text'>
With

  $ nmcli connection up "$PROFILE" ifname "$DEVICE"

it's clear that the user means the particular device. That also
is taken as a indication to make $DEVICE as managed, in case it was
unmanaged before. So, this command implies a previous

  $ nmcli device set $DEVICE managed yes

On the other hand, if the user just issues

  $ nmcli connection up "$PROFILE"

without a particular device, then we should prefer devices which
are marked as managed instead of unmanaged once.

Likewise, we should consider the device's state when selecting
a device. This means, when activating a profile which is activatable on
multiple devices, it will now prefer devices which are not already
active. The exception to this is that if the profile itself is already
active (and multi-connect "single"), then it will prefer to re-activate
the profile on the same device. This was done previously already. What's
new is that if the the profile is not multi-connect "single", the said
exception no longer applies, and we prefer to activate the profile on a
hitherto unactivated device.

https://bugzilla.redhat.com/show_bug.cgi?id=1639254

https://github.com/NetworkManager/NetworkManager/pull/232
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
With

  $ nmcli connection up "$PROFILE" ifname "$DEVICE"

it's clear that the user means the particular device. That also
is taken as a indication to make $DEVICE as managed, in case it was
unmanaged before. So, this command implies a previous

  $ nmcli device set $DEVICE managed yes

On the other hand, if the user just issues

  $ nmcli connection up "$PROFILE"

without a particular device, then we should prefer devices which
are marked as managed instead of unmanaged once.

Likewise, we should consider the device's state when selecting
a device. This means, when activating a profile which is activatable on
multiple devices, it will now prefer devices which are not already
active. The exception to this is that if the profile itself is already
active (and multi-connect "single"), then it will prefer to re-activate
the profile on the same device. This was done previously already. What's
new is that if the the profile is not multi-connect "single", the said
exception no longer applies, and we prefer to activate the profile on a
hitherto unactivated device.

https://bugzilla.redhat.com/show_bug.cgi?id=1639254

https://github.com/NetworkManager/NetworkManager/pull/232
</pre>
</div>
</content>
</entry>
<entry>
<title>po: update from Red Hat translators</title>
<updated>2018-10-16T14:48:27+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2018-10-16T14:28:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=7b8510a7e835d7d63df2cc553a8b18c68eb79bd4'/>
<id>7b8510a7e835d7d63df2cc553a8b18c68eb79bd4</id>
<content type='text'>
https://bugzilla.redhat.com/show_bug.cgi?id=1608323
(cherry picked from commit d7d085a88d6207c8362834adf407e807e9a89b68)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.redhat.com/show_bug.cgi?id=1608323
(cherry picked from commit d7d085a88d6207c8362834adf407e807e9a89b68)
</pre>
</div>
</content>
</entry>
<entry>
<title>dhcp: merge branch 'bg/dhcp-failed-rh1625901'</title>
<updated>2018-10-15T13:04:23+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2018-10-15T13:04:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=89caba77cbcdc1bb2160e0012c412c2458445b56'/>
<id>89caba77cbcdc1bb2160e0012c412c2458445b56</id>
<content type='text'>
https://github.com/NetworkManager/NetworkManager/pull/217
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://github.com/NetworkManager/NetworkManager/pull/217
</pre>
</div>
</content>
</entry>
<entry>
<title>dhcp: don't start grace period if the client is not running</title>
<updated>2018-10-15T12:05:23+00:00</updated>
<author>
<name>Beniamino Galvani</name>
<email>bgalvani@redhat.com</email>
</author>
<published>2018-09-28T13:58:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=567e277e64a8d9d7e9c46e8e61a6e15948c49279'/>
<id>567e277e64a8d9d7e9c46e8e61a6e15948c49279</id>
<content type='text'>
We shouldn't start a grace period when the client is not running.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We shouldn't start a grace period when the client is not running.
</pre>
</div>
</content>
</entry>
</feed>
