<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/NetworkManager.git, branch th/cli-strsplit</title>
<subtitle>gitlab.freedesktop.org: NetworkManager/NetworkManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/'/>
<entry>
<title>cli: drop nmc_strsplit_set()</title>
<updated>2017-12-11T14:53:24+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-12-08T09:44:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=7b08331b9d333aaa33e8f025069eb05f80b15ed4'/>
<id>7b08331b9d333aaa33e8f025069eb05f80b15ed4</id>
<content type='text'>
In most cases, it copies the entire strv needlessly.
We can do better.

Also, the max_tokens argument is handled wrongly (albeit
not used anywhere anymore).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In most cases, it copies the entire strv needlessly.
We can do better.

Also, the max_tokens argument is handled wrongly (albeit
not used anywhere anymore).
</pre>
</div>
</content>
</entry>
<entry>
<title>cli: refactor splitting of first command line argument</title>
<updated>2017-12-11T14:53:24+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-12-08T11:51:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=4a38e9338dd1bba68ff267d7716c6e8dd135c3d7'/>
<id>4a38e9338dd1bba68ff267d7716c6e8dd135c3d7</id>
<content type='text'>
nmc_strsplit_set() handles max_token wrong. It cannot call
g_strsplit_set() with max_token first, and then split empty
words. You cannot use g_strsplit_set() to achieve what
nmc_strsplit_set() wants to do, unless you first split all
tokens, then them construct them together again -- thereby
loosing the delimiters.

Anyway, there are just a few caller that do essentially the same.

Refactor the code to not use nmc_strsplit_set().
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
nmc_strsplit_set() handles max_token wrong. It cannot call
g_strsplit_set() with max_token first, and then split empty
words. You cannot use g_strsplit_set() to achieve what
nmc_strsplit_set() wants to do, unless you first split all
tokens, then them construct them together again -- thereby
loosing the delimiters.

Anyway, there are just a few caller that do essentially the same.

Refactor the code to not use nmc_strsplit_set().
</pre>
</div>
</content>
</entry>
<entry>
<title>cli: rework DEFINE_SETTER_PRIV_KEY()</title>
<updated>2017-12-11T14:53:24+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-12-08T09:44:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=ddcbc1b07a14abceaeefa39fc1dd923487ed8b14'/>
<id>ddcbc1b07a14abceaeefa39fc1dd923487ed8b14</id>
<content type='text'>
nmc_strsplit_set()'s max_token argument is broken,
because it *first* calls g_strsplit_set() and then removes
empty tokens. It wasn't an issue, because DEFINE_SETTER_PRIV_KEY()
would first already remove leading spaces, and who uses multiple
spaces anyway...

Anyway, refactor DEFINE_SETTER_PRIV_KEY() to not use it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
nmc_strsplit_set()'s max_token argument is broken,
because it *first* calls g_strsplit_set() and then removes
empty tokens. It wasn't an issue, because DEFINE_SETTER_PRIV_KEY()
would first already remove leading spaces, and who uses multiple
spaces anyway...

Anyway, refactor DEFINE_SETTER_PRIV_KEY() to not use it.
</pre>
</div>
</content>
</entry>
<entry>
<title>libnm: make nm_setting_802_1x_set_private_key() self-assignment safe</title>
<updated>2017-12-11T14:53:24+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-12-08T09:40:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=86554a37ed000c0f1d3cf76dcd9dd984efc690a5'/>
<id>86554a37ed000c0f1d3cf76dcd9dd984efc690a5</id>
<content type='text'>
nmcli calls nm_setting_802_1x_set_private_key() with a password pointer that
it just got from the setting connection itself. Make this less fragile, by
not freeing the current password before assigning it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
nmcli calls nm_setting_802_1x_set_private_key() with a password pointer that
it just got from the setting connection itself. Make this less fragile, by
not freeing the current password before assigning it.
</pre>
</div>
</content>
</entry>
<entry>
<title>settings: fix clearing nm-generated/volatile flags of connection</title>
<updated>2017-12-11T11:12:08+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-12-11T10:37:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=7044febf97debaf04b7f9ca4fbb2dc24fcf1b0b0'/>
<id>7044febf97debaf04b7f9ca4fbb2dc24fcf1b0b0</id>
<content type='text'>
There are a few cases where we don't want to clear a potential
nm-generated/volatile flag, but only mark the connection as
unsaved.

Otherwise, we wrongly end up clearing these flags and the connection
is wrongly not NM_DEVICE_SYS_IFACE_STATE_EXTERNAL.

Fixes: 35dc6421de78cffd1761cfb6edf9e94233f99966
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are a few cases where we don't want to clear a potential
nm-generated/volatile flag, but only mark the connection as
unsaved.

Otherwise, we wrongly end up clearing these flags and the connection
is wrongly not NM_DEVICE_SYS_IFACE_STATE_EXTERNAL.

Fixes: 35dc6421de78cffd1761cfb6edf9e94233f99966
</pre>
</div>
</content>
</entry>
<entry>
<title>lr/tc: initial support for TC qdiscs and filters</title>
<updated>2017-12-11T10:20:50+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2017-12-11T10:20:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=e75fc8279becce29e688551930d85e59e1280c89'/>
<id>e75fc8279becce29e688551930d85e59e1280c89</id>
<content type='text'>
https://bugzilla.gnome.org/show_bug.cgi?id=790630
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.gnome.org/show_bug.cgi?id=790630
</pre>
</div>
</content>
</entry>
<entry>
<title>ifcfg-rh: add tc support</title>
<updated>2017-12-11T10:20:13+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2017-12-08T13:13:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=902bbfdb1878ca54989e7aec6c5d92d1c580e885'/>
<id>902bbfdb1878ca54989e7aec6c5d92d1c580e885</id>
<content type='text'>
Format:

  QDISC1=ingress
  QDISC2="root handle 1234: fq_codel"
  FILTER1="parent ffff: matchall action simple sdata Input"
  FILTER2="parent 1234: matchall action simple sdata Output"
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Format:

  QDISC1=ingress
  QDISC2="root handle 1234: fq_codel"
  FILTER1="parent ffff: matchall action simple sdata Input"
  FILTER2="parent 1234: matchall action simple sdata Output"
</pre>
</div>
</content>
</entry>
<entry>
<title>device: set traffic filters when device comes up</title>
<updated>2017-12-11T10:20:13+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2017-11-28T13:10:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=8bffb2c7502fdfd4bebd595176d0842b3ccff2ab'/>
<id>8bffb2c7502fdfd4bebd595176d0842b3ccff2ab</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>platform: fix TC to-string/hash/cmp functions to include the action</title>
<updated>2017-12-11T10:08:41+00:00</updated>
<author>
<name>Thomas Haller</name>
<email>thaller@redhat.com</email>
</author>
<published>2017-12-10T11:52:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=fe3d7209e70944ec218d133cd66aa946e28c5a94'/>
<id>fe3d7209e70944ec218d133cd66aa946e28c5a94</id>
<content type='text'>
Also add a define NM_PLATFORM_ACTION_KIND_SIMPLE. It makes the
uses of "simple" grepable.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also add a define NM_PLATFORM_ACTION_KIND_SIMPLE. It makes the
uses of "simple" grepable.
</pre>
</div>
</content>
</entry>
<entry>
<title>platform: add support for traffic filters</title>
<updated>2017-12-11T10:08:41+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2017-11-15T19:36:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/NetworkManager.git/commit/?id=b0fd3ecbaf800c7c70104f0809b0f1e2fb18e1f8'/>
<id>b0fd3ecbaf800c7c70104f0809b0f1e2fb18e1f8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
