delta/NetworkManager.git, branch bg/issue93

vpn: add route to vpn gw when parent has a default device route

2019-02-04T08:43:12+00:00

When the parent device has a device default route (i.e. without
gateway) and we establish a VPN on top of it, 'ip route get' for the
VPN gateway returns a device route, which is the same result we get
for an unreachable VPN gateway. However it is necessary to add the
route to the gateway or otherwise it will possibly become unreachable
once the VPN gets activated.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/93

wifi-p2p: merge branch 'th/wifi-p2p-various' (pt1)

2019-02-01T16:34:07+00:00

https://github.com/NetworkManager/NetworkManager/pull/290

clients/trivial: move code in nm-meta-setting-desc around

2019-02-01T16:02:57+00:00

Sort by name.

wifi-p2p: rename Wi-Fi P2P

2019-02-01T16:02:57+00:00

After renaming the files, also rename all the content
to follow the "Wi-Fi P2P" naming scheme.

wifi-p2p: rename files for consistent Wi-Fi P2P naming

2019-02-01T16:02:57+00:00

We named the types inconsistently:

  - "p2p-wireless" ("libnm-core/nm-setting-p2p-wireless.h")

  - "p2p" ("libnm/nm-p2p-peer.h")

  - "p2p-wifi" ("src/devices/wifi/nm-device-p2p-wifi.h")

It seems to me, "libnm/nm-p2p-peer.h" should be qualified with a "Wi-Fi"
specific name. It's not just peer-to-peer, it's Wi-Fi P2P.
Yes, there is an inconsistency now, because there is already
"libnm/nm-access-point.h".

It seems to me (from looking at the internet), that the name "Wi-Fi P2P"
is more common than "P2P Wi-Fi" -- although both are used. There is also
the name "Wi-Fi Direct". But it's not clear which name should be
preferred here, so stick to "Wi-Fi P2P".

In this first commit only rename the files. The following commit will
rename the content.

core/device-p2p-wifi: drop unused code

2019-02-01T16:02:57+00:00

If this is going to be implemented, revert the patch.

core/device-p2p-wifi/trival: move code

2019-02-01T16:02:57+00:00

Have the class_init() function at the bottom.

core/p2p-wifi: various minor cleanups

2019-02-01T16:02:57+00:00

libnm/device-p2p-wifi: drop API that still needs consideration

2019-02-01T16:02:57+00:00

Having synchronous API is wrong, or at least questionable.
Granted, libnm isn't currently very good about the exact order
of things to happen. However synchronous API by design delays events
while waiting for the response and hence messes up the ordering.

Maybe synchronous API should not be added to libnm.

Or at least, if we have synchronous API, we certainly need an asynchrnous
variant as well (which is still missing).

As synchronous API is not preferred, it should also be named
nm_some_thing_sync(), accompanied by nm_some_thing() and
nm_some_thing_finish(). The name for the synchronous method should be the
odd one and we shouldn't have an nm_some_thing_async(). Yes, libnm is not
consistend about that.

I am going to drop this API for the moment.

libnm-core/setting-p2p-wifi: drop unused code

2019-02-01T16:02:57+00:00

If this is going to be implemented, revert the patch.