<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/ModemManager.git/test, branch main</title>
<subtitle>gitlab.freedesktop.org: mobile-broadband/ModemManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/'/>
<entry>
<title>port-serial-at: make mm_port_serial_at_command_finish() transfer ownership</title>
<updated>2023-04-11T13:49:03+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2023-01-08T18:57:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=c40876de956311ef9a17b920486263d46f4fef3b'/>
<id>c40876de956311ef9a17b920486263d46f4fef3b</id>
<content type='text'>
This will make it slightly easier to port mm_port_serial_at_command() to
use GTask, since we won't have to keep a pointer to the result in GTask
after _finish() has been called.

In most cases the caller needs the value anyway, so this doesn't add too
much hasle.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will make it slightly easier to port mm_port_serial_at_command() to
use GTask, since we won't have to keep a pointer to the result in GTask
after _finish() has been called.

In most cases the caller needs the value anyway, so this doesn't add too
much hasle.
</pre>
</div>
</content>
</entry>
<entry>
<title>test: fix _mm_log() prototypes</title>
<updated>2023-04-10T09:21:46+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2023-03-30T10:53:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=1da5b81fefe985ccf74dbd981755c047e21ebcbc'/>
<id>1da5b81fefe985ccf74dbd981755c047e21ebcbc</id>
<content type='text'>
GCC 13 is unhappy to cast a MMLogLevel to a guint32:

  [188/539] Compiling C object src/plugins/test-shared-icera.p/icera_tests_test-modem-helpers-icera.c.o
  In file included from ../src/plugins/icera/tests/test-modem-helpers-icera.c:27:
  ../src/mm-log-test.h:25:1: warning: conflicting types for ‘_mm_log’ due to enum/integer mismatch; have ‘void(void *, const gchar *, const gchar *, const gchar *, guint32,  const gchar *, ...)’ {aka ‘void(void *, const char *, const char *, const char *, unsigned int,  const char *, ...)’} [-Wenum-int-mismatch]
     25 | _mm_log (gpointer     obj,
        | ^~~~~~~
  In file included from ../src/mm-log-test.h:20:
  ../src/mm-log.h:61:6: note: previous declaration of ‘_mm_log’ with type ‘void(void *, const gchar *, const gchar *, const gchar *, MMLogLevel,  const gchar *, ...)’ {aka ‘void(void *, const char *, const char *, const char *, MMLogLevel,  const char *, ...)’}
     61 | void _mm_log (gpointer     obj,
        |      ^~~~~~~

That's perfectly fine, just use the enum type directly.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
GCC 13 is unhappy to cast a MMLogLevel to a guint32:

  [188/539] Compiling C object src/plugins/test-shared-icera.p/icera_tests_test-modem-helpers-icera.c.o
  In file included from ../src/plugins/icera/tests/test-modem-helpers-icera.c:27:
  ../src/mm-log-test.h:25:1: warning: conflicting types for ‘_mm_log’ due to enum/integer mismatch; have ‘void(void *, const gchar *, const gchar *, const gchar *, guint32,  const gchar *, ...)’ {aka ‘void(void *, const char *, const char *, const char *, unsigned int,  const char *, ...)’} [-Wenum-int-mismatch]
     25 | _mm_log (gpointer     obj,
        | ^~~~~~~
  In file included from ../src/mm-log-test.h:20:
  ../src/mm-log.h:61:6: note: previous declaration of ‘_mm_log’ with type ‘void(void *, const gchar *, const gchar *, const gchar *, MMLogLevel,  const gchar *, ...)’ {aka ‘void(void *, const char *, const char *, const char *, MMLogLevel,  const char *, ...)’}
     61 | void _mm_log (gpointer     obj,
        |      ^~~~~~~

That's perfectly fine, just use the enum type directly.
</pre>
</div>
</content>
</entry>
<entry>
<title>mmtty: handle MM_LOG_LEVEL_MSG in _mm_log()</title>
<updated>2023-04-10T09:21:46+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2023-03-30T10:58:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=df4aea5adaee2bb62948e822b617b0341c3c43d5'/>
<id>df4aea5adaee2bb62948e822b617b0341c3c43d5</id>
<content type='text'>
GCC 13 is unhappy about mixing enums and ints. However, if we fix the
type un mmtty's _mm_log() prototype, the compiler will find something
else to be irritiated about:

  [1/2] Compiling C object test/mmtty.p/mmtty.c.o
  ../test/mmtty.c: In function ‘_mm_log’:
  ../test/mmtty.c:283:5: warning: enumeration value ‘MM_LOG_LEVEL_MSG’ not handled in switch [-Wswitch-enum]
    283 |     switch (level) {
        |     ^~~~~~
  [2/2] Linking target test/mmtty

Fix that first.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
GCC 13 is unhappy about mixing enums and ints. However, if we fix the
type un mmtty's _mm_log() prototype, the compiler will find something
else to be irritiated about:

  [1/2] Compiling C object test/mmtty.p/mmtty.c.o
  ../test/mmtty.c: In function ‘_mm_log’:
  ../test/mmtty.c:283:5: warning: enumeration value ‘MM_LOG_LEVEL_MSG’ not handled in switch [-Wswitch-enum]
    283 |     switch (level) {
        |     ^~~~~~
  [2/2] Linking target test/mmtty

Fix that first.
</pre>
</div>
</content>
</entry>
<entry>
<title>test,mmsmspdu: fix verbose logging support</title>
<updated>2023-03-30T20:14:44+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksandermj@chromium.org</email>
</author>
<published>2023-03-30T19:36:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=7ec71020e73e486d5070864b5c9ecaa580a68b99'/>
<id>7ec71020e73e486d5070864b5c9ecaa580a68b99</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>build: drop autotools</title>
<updated>2022-11-07T14:26:02+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksandermj@chromium.org</email>
</author>
<published>2022-10-27T20:41:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=f419f56628fdcbf4bd5865d0d61147066ba27b17'/>
<id>f419f56628fdcbf4bd5865d0d61147066ba27b17</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>core: switch bash shell scripts to use /bin/sh for use w/Busybox.</title>
<updated>2022-01-05T09:26:16+00:00</updated>
<author>
<name>Bruce A. Johnson</name>
<email>waterfordtrack@gmail.com</email>
</author>
<published>2021-12-22T19:24:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=91ed72aa29ede06d3a5115128e2267793ca611d4'/>
<id>91ed72aa29ede06d3a5115128e2267793ca611d4</id>
<content type='text'>
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/483
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/483
</pre>
</div>
</content>
</entry>
<entry>
<title>build,meson: Make feature options boolean</title>
<updated>2021-11-08T09:28:55+00:00</updated>
<author>
<name>Iñigo Martínez</name>
<email>inigomartinez@gmail.com</email>
</author>
<published>2021-11-05T11:45:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=ec2e5403f14892047f391f63982bf5e4b30438c2'/>
<id>ec2e5403f14892047f391f63982bf5e4b30438c2</id>
<content type='text'>
Different options are set as `feature`, also every possible plugin,
but this may cause confusion.

All options set as `feature` but plugins have been made `boolean` to
avoid further confusions.

`help2man` is also installed in the CI image because is required to
build different libraries.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Different options are set as `feature`, also every possible plugin,
but this may cause confusion.

All options set as `feature` but plugins have been made `boolean` to
avoid further confusions.

`help2man` is also installed in the CI image because is required to
build different libraries.
</pre>
</div>
</content>
</entry>
<entry>
<title>core: replace 'dummy' with 'placeholder'</title>
<updated>2021-11-04T21:44:20+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksander@aleksander.es</email>
</author>
<published>2021-11-04T21:44:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=9f679d4cacde106a14ac68350c7173d31c1a3e5d'/>
<id>9f679d4cacde106a14ac68350c7173d31c1a3e5d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Tests: fix -Wformat compiler warning</title>
<updated>2021-09-17T10:10:31+00:00</updated>
<author>
<name>Yegor Yefremov</name>
<email>yegorslists@googlemail.com</email>
</author>
<published>2021-09-17T09:14:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=4875817f19d035694e234dd26448d43d92422468'/>
<id>4875817f19d035694e234dd26448d43d92422468</id>
<content type='text'>
Use G_GUINT64_FORMAT to properly format a guint64 type.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use G_GUINT64_FORMAT to properly format a guint64 type.
</pre>
</div>
</content>
</entry>
<entry>
<title>test,lsudev: add attribute format to println()</title>
<updated>2021-09-07T10:55:43+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksander@aleksander.es</email>
</author>
<published>2021-09-07T09:24:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=145bbb40102f5d44db2877b7379f08a0993c7b57'/>
<id>145bbb40102f5d44db2877b7379f08a0993c7b57</id>
<content type='text'>
  ../test/lsudev.c: In function ‘println’:
  ../test/lsudev.c:68:5: warning: function ‘println’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
     68 |     g_string_append_vprintf (output, fmt, args);
        |     ^~~~~~~~~~~~~~~~~~~~~~~
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  ../test/lsudev.c: In function ‘println’:
  ../test/lsudev.c:68:5: warning: function ‘println’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
     68 |     g_string_append_vprintf (output, fmt, args);
        |     ^~~~~~~~~~~~~~~~~~~~~~~
</pre>
</div>
</content>
</entry>
</feed>
