<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/ModemManager.git/src/plugins/cinterion, branch main</title>
<subtitle>gitlab.freedesktop.org: mobile-broadband/ModemManager.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/'/>
<entry>
<title>port-serial-at: make mm_port_serial_at_command_finish() transfer ownership</title>
<updated>2023-04-11T13:49:03+00:00</updated>
<author>
<name>Lubomir Rintel</name>
<email>lkundrak@v3.sk</email>
</author>
<published>2023-01-08T18:57:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=c40876de956311ef9a17b920486263d46f4fef3b'/>
<id>c40876de956311ef9a17b920486263d46f4fef3b</id>
<content type='text'>
This will make it slightly easier to port mm_port_serial_at_command() to
use GTask, since we won't have to keep a pointer to the result in GTask
after _finish() has been called.

In most cases the caller needs the value anyway, so this doesn't add too
much hasle.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will make it slightly easier to port mm_port_serial_at_command() to
use GTask, since we won't have to keep a pointer to the result in GTask
after _finish() has been called.

In most cases the caller needs the value anyway, so this doesn't add too
much hasle.
</pre>
</div>
</content>
</entry>
<entry>
<title>cinterion: fix missing object in mm_obj_dbg() calls</title>
<updated>2023-04-10T15:06:28+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksandermj@chromium.org</email>
</author>
<published>2023-04-10T15:06:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=e3c3604838cd1931b3fdc9cfa58a4292c7b9ba6f'/>
<id>e3c3604838cd1931b3fdc9cfa58a4292c7b9ba6f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>cinterion: fix warning with -Wmissing-prototypes</title>
<updated>2023-04-10T15:05:24+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksandermj@chromium.org</email>
</author>
<published>2023-04-10T15:05:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=a53990e0740c93d397d06376989cceb96b15a2ad'/>
<id>a53990e0740c93d397d06376989cceb96b15a2ad</id>
<content type='text'>
  ../src/plugins/cinterion/mm-plugin-cinterion.c:65:1: warning: no previous prototype for ‘is_port_already_tagged’ [-Wmissing-prototypes]
     65 | is_port_already_tagged (MMPortProbe *probe)
        | ^~~~~~~~~~~~~~~~~~~~~~
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
  ../src/plugins/cinterion/mm-plugin-cinterion.c:65:1: warning: no previous prototype for ‘is_port_already_tagged’ [-Wmissing-prototypes]
     65 | is_port_already_tagged (MMPortProbe *probe)
        | ^~~~~~~~~~~~~~~~~~~~~~
</pre>
</div>
</content>
</entry>
<entry>
<title>cinterion: use port type hints on modem probe</title>
<updated>2023-04-10T09:52:26+00:00</updated>
<author>
<name>Konrad Zapałowicz</name>
<email>konrad.zapalowicz@rigado.com</email>
</author>
<published>2022-04-18T19:35:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=4f4bd48db90ce329dc491db57a5e17b9002ea380'/>
<id>4f4bd48db90ce329dc491db57a5e17b9002ea380</id>
<content type='text'>
The Cinterion plugin is using the output of the SQPORT? to guess which
ports can be used for AT commands and data connection.

Yet at the same time the udev adds port type hints to the Cinterion
modem upon its discovery.

This commit changes the initialization in a way that from now on it
skips sending SQPORT? when the port type hints are already assigned. By
doing this we make sure that the udev port type hints are being used
when they are available. In case they are not the initialization relies
on the outout of SQPORT? as it did do far.

See: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/782
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The Cinterion plugin is using the output of the SQPORT? to guess which
ports can be used for AT commands and data connection.

Yet at the same time the udev adds port type hints to the Cinterion
modem upon its discovery.

This commit changes the initialization in a way that from now on it
skips sending SQPORT? when the port type hints are already assigned. By
doing this we make sure that the udev port type hints are being used
when they are available. In case they are not the initialization relies
on the outout of SQPORT? as it did do far.

See: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/782
</pre>
</div>
</content>
</entry>
<entry>
<title>cinterion: don't assume GError structure always initialized</title>
<updated>2023-03-15T11:02:36+00:00</updated>
<author>
<name>Kirill Buksha</name>
<email>kirbuk200@gmail.com</email>
</author>
<published>2023-03-14T15:48:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=c46380749420d4a9161b3a0e3d8b8e18d6079cb6'/>
<id>c46380749420d4a9161b3a0e3d8b8e18d6079cb6</id>
<content type='text'>
GError structure may not be initialized after execution of
mm_3gpp_parse_cgdcont_read_response() and accessing it's
fields will cause a segmentation fault.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
GError structure may not be initialized after execution of
mm_3gpp_parse_cgdcont_read_response() and accessing it's
fields will cause a segmentation fault.
</pre>
</div>
</content>
</entry>
<entry>
<title>plugins: setup new helper macros to define plugins</title>
<updated>2023-01-03T13:56:25+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksandermj@chromium.org</email>
</author>
<published>2022-12-11T21:48:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=f0a9f0955846187ca6e6a04a0ca191ba2592d5af'/>
<id>f0a9f0955846187ca6e6a04a0ca191ba2592d5af</id>
<content type='text'>
We also remove the plugin headers completely as they are not really
required anywhere.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We also remove the plugin headers completely as they are not really
required anywhere.
</pre>
</div>
</content>
</entry>
<entry>
<title>build: move plugins directory to src/plugins</title>
<updated>2023-01-03T13:56:25+00:00</updated>
<author>
<name>Aleksander Morgado</name>
<email>aleksandermj@chromium.org</email>
</author>
<published>2022-12-08T13:37:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ModemManager.git/commit/?id=e14b904cbd6816cb0227d519d308ae71ddaf6e07'/>
<id>e14b904cbd6816cb0227d519d308ae71ddaf6e07</id>
<content type='text'>
We are going to allow including the plugin sources built within the
ModemManager daemon binary; moving the sources within the daemon
sources directory makes it easier.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We are going to allow including the plugin sources built within the
ModemManager daemon binary; moving the sources within the daemon
sources directory makes it easier.
</pre>
</div>
</content>
</entry>
</feed>
