diff options
author | Johnny Willemsen <jwillemsen@remedy.nl> | 2019-04-12 17:25:18 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-04-12 17:25:18 +0200 |
commit | 970549d1b751146de0284cf04df79e7714621e95 (patch) | |
tree | 9847cf2d4af01f638a0ee7a25a095ad05bd1e6a9 | |
parent | 6077b11bb47d50d264f1ed095df2a0c499f74c90 (diff) | |
parent | c905cde373f47cb7efa87f74a3164767a0afd762 (diff) | |
download | ATCD-970549d1b751146de0284cf04df79e7714621e95.tar.gz |
Merge pull request #888 from jwillemsen/master
ImplRepo logging and layout changes
19 files changed, 56 insertions, 140 deletions
diff --git a/TAO/bin/imr_tests.lst b/TAO/bin/imr_tests.lst deleted file mode 100644 index cdbba6e75ba..00000000000 --- a/TAO/bin/imr_tests.lst +++ /dev/null @@ -1,65 +0,0 @@ -# This is the list of run_test.pl's that need to be run by -# auto_run_tests.pl. -# Each line has its own test, and a test can be followed by a -# list of configurations it does _not_ run on. -# -# Example: TAO\examples\foo\run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !ST -# -# NOTE: This file contains examples and other service level test for -# TAO's. Please do not include regular tests here. -TAO/orbsvcs/tests/ImplRepo/run_test.pl both_ir: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl nestea_ir: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl airplane_ir: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl persistent_ir: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl nt_service_ir: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR Win32 !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl shutdown: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO !OSX -TAO/orbsvcs/tests/ImplRepo/run_test.pl perclient: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl persistent_ir_hash: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !OSX -TAO/orbsvcs/tests/ImplRepo/run_test.pl persistent_ir_shared: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !Win32 -TAO/orbsvcs/tests/ImplRepo/run_test.pl failover -replica: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !Win32 -TAO/orbsvcs/tests/ImplRepo/run_test.pl backup_restart -replica: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !Win32 -TAO/orbsvcs/tests/ImplRepo/run_test.pl persistent_ft -replica: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !Win32 -TAO/orbsvcs/tests/ImplRepo/run_test.pl persistent_listingcorrupt -replica: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !Win32 -TAO/orbsvcs/tests/ImplRepo/run_test.pl persistent_activatorcorrupt -replica: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !Win32 -TAO/orbsvcs/tests/ImplRepo/run_test.pl persistent_servercorrupt -replica: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !Win32 -TAO/orbsvcs/tests/ImplRepo/run_test.pl manual_persistent_restart: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl manual_persistent_restart_hash: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl manual_persistent_restart_shared: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/run_test.pl manual_persistent_restart_registry: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO Win32 -TAO/orbsvcs/tests/ImplRepo/NameService/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/PICurrent/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/double_start/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !Win32 -TAO/orbsvcs/tests/ImplRepo/double_start/run_test.pl -kill: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !Win32 !FIXED_BUGS_ONLY -TAO/orbsvcs/tests/ImplRepo/kill_server/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/kill_server/run_test.pl -rm2523: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/kill_server/run_test.pl -rm2523 -start_delay 3: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/kill_server/run_test.pl -rm2523 -force: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/kill_server/run_test.pl -rm2523 -force -signal 15: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/kill_server/run_test.pl -rm2523ol: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/kill_slow_server/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/oneway/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/locked/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO !OSX -TAO/orbsvcs/tests/ImplRepo/manual_start/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !LynxOS !ACE_FOR_TAO !OpenVMS -TAO/orbsvcs/tests/ImplRepo/scale/run_test.pl -servers 5 -objects 5: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/scale_clients/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/servers_list/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/servers_list/run_test_ft.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/Bug_689_Regression/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO -TAO/orbsvcs/tests/ImplRepo/Bug_2604_Regression/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/Bug_4152_Regression/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/ReconnectServer/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/ReconnectServer/run_test.pl -forwardalways: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/ReconnectServer/run_test.pl -forwardonce: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/ReconnectServer/run_test.pl -pingexternal: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS -TAO/orbsvcs/tests/ImplRepo/RestartServer/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/RestartServer/run_test.pl -manual: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/RestartServer/run_test.pl -manual -lockout: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/servers_interact_on_startup/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/servers_interact_on_startup/run_test.pl -delay 20 -imr_start: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/servers_interact_on_startup/run_test.pl -hide_server -imr_start: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/servers_interact_on_startup/run_test.pl -multistart: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/ping_interrupt/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/link_poas/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/RestartIMR/run_test.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/tests/ImplRepo/RestartIMR/run_test.pl -kill_server: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !WCHAR !ACE_FOR_TAO !LynxOS !OpenVMS -TAO/orbsvcs/examples/ImR/Combined_Service/run_test.pl: !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !STATIC !ST !ACE_FOR_TAO !LynxOS diff --git a/TAO/bin/name_tests.lst b/TAO/bin/name_tests.lst deleted file mode 100644 index faa4b3974df..00000000000 --- a/TAO/bin/name_tests.lst +++ /dev/null @@ -1,21 +0,0 @@ -# This list is a duplicate of just the name service tests from tao_other_test.lst -# It is simply for local pre-commit coverage of changes isolated to the Name service. -# -TAO/orbsvcs/tests/Simple_Naming/run_test.pl: !ST !NO_MESSAGING !ACE_FOR_TAO !LynxOS !CORBA_E_MICRO !DISTRIBUTED !OSX -TAO/orbsvcs/tests/Simple_Naming/run_test.pl -nommap: !ST !NO_MESSAGING !ACE_FOR_TAO !LynxOS !CORBA_E_MICRO !DISTRIBUTED OSX -TAO/orbsvcs/tests/Simple_Naming/run_test_ffp.pl: !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !NO_MESSAGING !ACE_FOR_TAO !DISTRIBUTED -TAO/orbsvcs/tests/Simple_Naming/run_test_ft.pl: !Win32 !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !NO_MESSAGING !ACE_FOR_TAO !DISTRIBUTED -TAO/orbsvcs/tests/Redundant_Naming/run_test.pl: !Win32 !ST !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !ACE_FOR_TAO !DISTRIBUTED -TAO/orbsvcs/tests/Simple_Naming/run_test_ipv6.pl: IPV6 !ST !NO_MESSAGING !ACE_FOR_TAO !LynxOS !CORBA_E_MICRO !DISTRIBUTED -TAO/orbsvcs/DevGuideExamples/NamingService/Messenger/run_test.pl: !CORBA_E_COMPACT !CORBA_E_MICRO !LynxOS -TAO/orbsvcs/DevGuideExamples/NamingService/Naming_Client/run_test.pl: !CORBA_E_COMPACT !CORBA_E_MICRO !LynxOS -TAO/orbsvcs/DevGuideExamples/NamingService/Naming_Context_Ext/run_test.pl: !CORBA_E_COMPACT !CORBA_E_MICRO !LynxOS -TAO/orbsvcs/DevGuideExamples/NamingService/Naming_Server/run_test.pl: !ST !NO_MCAST !NO_MESSAGING !CORBA_E_COMPACT !CORBA_E_MICRO -TAO/orbsvcs/DevGuideExamples/NamingService/corbaloc_Messenger/run_test.pl: !CORBA_E_COMPACT !CORBA_E_MICRO !LynxOS -TAO/orbsvcs/DevGuideExamples/NamingService/corbaname_Messenger/run_test.pl: !CORBA_E_COMPACT !CORBA_E_MICRO !LynxOS -TAO/utils/nsgroup/run_test.pl: !Win32 !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !DISABLE_INTERCEPTORS !STATIC !ACE_FOR_TAO !LynxOS !ST -TAO/orbsvcs/tests/FT_Naming/Load_Balancing/run_test.pl: !Win32 !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !DISABLE_INTERCEPTORS !ACE_FOR_TAO !LynxOS !ST -TAO/orbsvcs/tests/FT_Naming/Replication/run_test.pl: !Win32 !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !DISABLE_INTERCEPTORS !ACE_FOR_TAO !LynxOS !ST -TAO/orbsvcs/tests/FT_Naming/FaultTolerant/run_test.pl: !Win32 !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !DISABLE_INTERCEPTORS !ACE_FOR_TAO !LynxOS !ST -TAO/orbsvcs/tests/FT_Naming/Federation/run_test.pl: !Win32 !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !DISABLE_INTERCEPTORS !ACE_FOR_TAO !LynxOS !ST -TAO/orbsvcs/tests/FT_Naming/stress_storable/run_test.pl: !Win32 !MINIMUM !CORBA_E_COMPACT !CORBA_E_MICRO !DISABLE_INTERCEPTORS !ACE_FOR_TAO !LynxOS !ST diff --git a/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.cpp b/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.cpp index b5603c1081f..456dde6b655 100644 --- a/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.cpp +++ b/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.cpp @@ -230,7 +230,7 @@ AsyncAccessManager::final_state (bool active) if (ImR_Locator_i::debug () > 5) { ORBSVCS_DEBUG ((LM_DEBUG, - ACE_TEXT ("(%P|%t) AsyncAccessManager(%@)::final_state ") + ACE_TEXT ("(%P|%t) AsyncAccessManager(%@)::final_state - ") ACE_TEXT ("removing this from map, server <%C> remove_on_death_rh_ <%@>\n"), this, info_->ping_id (), this->remove_on_death_rh_)); } @@ -253,10 +253,24 @@ AsyncAccessManager::notify_waiter (ImR_ResponseHandler *rh) { if (this->info_->is_mode (ImplementationRepository::PER_CLIENT)) { + if (ImR_Locator_i::debug () > 5) + { + ORBSVCS_DEBUG ((LM_DEBUG, + ACE_TEXT ("(%P|%t) AsyncAccessManager(%@)::notify_waiter - ") + ACE_TEXT ("For unique server <%C> reporting back IOR <%C>\n"), + this, info_->ping_id (), this->partial_ior_.c_str())); + } rh->send_ior (this->partial_ior_.c_str()); } else { + if (ImR_Locator_i::debug () > 5) + { + ORBSVCS_DEBUG ((LM_DEBUG, + ACE_TEXT ("(%P|%t) AsyncAccessManager(%@)::notify_waiter - ") + ACE_TEXT ("For server <%C> reporting back IOR <%C>\n"), + this, info_->ping_id (), this->info_->partial_ior.c_str())); + } rh->send_ior (this->info_->partial_ior.c_str()); } } @@ -775,6 +789,12 @@ ActivatorReceiver::start_server_excep (Messaging::ExceptionHolder *holder) } catch (const ImplementationRepository::CannotActivate &ca) { + if (ImR_Locator_i::debug () > 1) + { + ORBSVCS_DEBUG ((LM_DEBUG, + ACE_TEXT ("(%P|%t) ActivatorReceiver(%@)::start_server_excep, reason <%C>\n"), + this, ca.reason.in ())); + } if (ACE_OS::strstr (ca.reason.in(),"pid:") == ca.reason.in()) { int const pid = ACE_OS::atoi (ca.reason.in()+4); @@ -785,6 +805,14 @@ ActivatorReceiver::start_server_excep (Messaging::ExceptionHolder *holder) this->aam_->activator_replied_start_running (false, 0); } } + catch (const CORBA::Exception& ex) + { + if (ImR_Locator_i::debug () > 1) + { + ex._tao_print_exception ("ActivatorReceiver::start_server_excep"); + } + } + PortableServer::ObjectId_var oid = this->poa_->servant_to_id (this); poa_->deactivate_object (oid.in()); } diff --git a/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.h b/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.h index 1af3d7aa3b1..c02044b617a 100644 --- a/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.h +++ b/TAO/orbsvcs/ImplRepo_Service/AsyncAccessManager.h @@ -60,7 +60,7 @@ class Locator_Export AsyncAccessManager bool is_terminating (void) const; bool is_running (void) const; - bool has_server (const char *name) const ; + bool has_server (const char *name) const; void remote_state (ImplementationRepository::AAM_Status s); void add_interest (ImR_ResponseHandler *rh, bool manual); diff --git a/TAO/orbsvcs/ImplRepo_Service/Forwarder.cpp b/TAO/orbsvcs/ImplRepo_Service/Forwarder.cpp index 3ea492fdd0c..cc88f060de7 100644 --- a/TAO/orbsvcs/ImplRepo_Service/Forwarder.cpp +++ b/TAO/orbsvcs/ImplRepo_Service/Forwarder.cpp @@ -199,7 +199,7 @@ ImR_DSI_ResponseHandler::send_ior (const char *pior) { ORBSVCS_ERROR ((LM_ERROR, ACE_TEXT ("(%P|%t) ImR_DSI_ResponseHandler::send_ior (): Forward_to ") - ACE_TEXT ("reference is nil.\n"))); + ACE_TEXT ("reference is nil\n"))); } } else diff --git a/TAO/orbsvcs/ImplRepo_Service/ImR_Activator.cpp b/TAO/orbsvcs/ImplRepo_Service/ImR_Activator.cpp index d190a34fcb1..43c20f68948 100644 --- a/TAO/orbsvcs/ImplRepo_Service/ImR_Activator.cpp +++ b/TAO/orbsvcs/ImplRepo_Service/ImR_Activator.cpp @@ -150,7 +150,7 @@ run_service_command (Activator_Options& opts) } if (ret != -1) { - ORBSVCS_DEBUG ((LM_DEBUG, "ImR Activator: Service installed.\n")); + ORBSVCS_DEBUG ((LM_DEBUG, "ImR Activator: Service installed\n")); opts.save_registry_options (); } else @@ -163,7 +163,7 @@ run_service_command (Activator_Options& opts) else if (opts.service_command () == Activator_Options::SC_REMOVE) { int ret = SERVICE::instance ()->remove (); - ORBSVCS_DEBUG ((LM_DEBUG, "ImR Activator: Service removed.\n")); + ORBSVCS_DEBUG ((LM_DEBUG, "ImR Activator: Service removed\n")); if (ret == 0) return 1; // If successful, then we don't want to continue. } diff --git a/TAO/orbsvcs/ImplRepo_Service/ImR_Activator_i.cpp b/TAO/orbsvcs/ImplRepo_Service/ImR_Activator_i.cpp index a7443d5e356..819f35b7f4f 100644 --- a/TAO/orbsvcs/ImplRepo_Service/ImR_Activator_i.cpp +++ b/TAO/orbsvcs/ImplRepo_Service/ImR_Activator_i.cpp @@ -107,7 +107,7 @@ ImR_Activator_i::register_with_imr (ImplementationRepository::Activator_ptr acti locator_->register_activator (name_.c_str (), activator); if (debug_ > 0) - ORBSVCS_DEBUG((LM_DEBUG, "(%P|%t) ImR Activator: Registered with ImR.\n")); + ORBSVCS_DEBUG((LM_DEBUG, "(%P|%t) ImR Activator: Registered with ImR\n")); return; } @@ -123,7 +123,7 @@ ImR_Activator_i::register_with_imr (ImplementationRepository::Activator_ptr acti } if (debug_ > 0) - ORBSVCS_DEBUG ((LM_DEBUG, "(%P|%t) ImR Activator: Not registered with ImR.\n")); + ORBSVCS_DEBUG ((LM_DEBUG, "(%P|%t) ImR Activator: Not registered with ImR\n")); } int @@ -260,13 +260,13 @@ ImR_Activator_i::fini (void) { if (debug_ > 1) ORBSVCS_ERROR ((LM_ERROR, - ACE_TEXT ("(%P|%t) ImR Activator: COMM_FAILURE, unable to unregister from ImR.\n"))); + ACE_TEXT ("(%P|%t) ImR Activator: COMM_FAILURE, unable to unregister from ImR\n"))); } catch (const CORBA::TRANSIENT&) { if (debug_ > 1) ORBSVCS_ERROR ((LM_ERROR, - ACE_TEXT ("(%P|%t) ImR Activator: TRANSIENT, unable to unregister from ImR.\n"))); + ACE_TEXT ("(%P|%t) ImR Activator: TRANSIENT, unable to unregister from ImR\n"))); } catch (const CORBA::Exception& ex) { @@ -279,7 +279,7 @@ ImR_Activator_i::fini (void) this->orb_->destroy (); if (debug_ > 0) - ORBSVCS_DEBUG ((LM_DEBUG, "(%P|%t) ImR Activator: Shut down successfully.\n")); + ORBSVCS_DEBUG ((LM_DEBUG, "(%P|%t) ImR Activator: Shut down successfully\n")); } catch (const CORBA::Exception& ex) { @@ -323,7 +323,9 @@ ImR_Activator_i::shutdown (bool signaled) if (signaled && this->in_upcall ()) { if (debug_ > 0) - ORBSVCS_DEBUG ((LM_DEBUG, "(%P|%t) ImR Activator: ignoring signal during upcall.\n")); + { + ORBSVCS_DEBUG ((LM_DEBUG, "(%P|%t) ImR Activator: ignoring signal during upcall\n")); + } return; } if (! CORBA::is_nil (this->locator_.in ()) && this->registration_token_ != 0) @@ -472,8 +474,8 @@ ImR_Activator_i::start_server(const char* name, if (debug_ > 0) { ORBSVCS_ERROR((LM_ERROR, - "(%P|%t) ImR Activator: Unique instance already running pid <%d>\n", - static_cast<int> (pid))); + "(%P|%t) ImR Activator: Unique instance for <%C> already running pid <%d>\n", + name, static_cast<int> (pid))); } char reason[32]; ACE_OS::snprintf (reason,32,"pid:%d",static_cast<int> (pid)); @@ -556,7 +558,7 @@ ImR_Activator_i::start_server(const char* name, { ORBSVCS_DEBUG ((LM_DEBUG, ACE_TEXT ("(%P|%t) ImR Activator: Notifying ImR that ") - ACE_TEXT ("<%C> has started with pid <%d>.\n"), + ACE_TEXT ("<%C> has started with pid <%d>\n"), name, static_cast<int> (pid))); } try diff --git a/TAO/orbsvcs/ImplRepo_Service/ImR_Locator_i.cpp b/TAO/orbsvcs/ImplRepo_Service/ImR_Locator_i.cpp index acbe55ff81a..62f816fc231 100644 --- a/TAO/orbsvcs/ImplRepo_Service/ImR_Locator_i.cpp +++ b/TAO/orbsvcs/ImplRepo_Service/ImR_Locator_i.cpp @@ -485,7 +485,7 @@ ImR_Locator_i::child_death_i (const char* name, int pid) if (debug_ > 1) { ORBSVCS_DEBUG ((LM_DEBUG, - ACE_TEXT ("(%P|%t) ImR: Server <%C> has died with pid <%d>.\n"), + ACE_TEXT ("(%P|%t) ImR: Server <%C> has died with pid <%d>\n"), name, pid)); } diff --git a/TAO/orbsvcs/ImplRepo_Service/LiveCheck.cpp b/TAO/orbsvcs/ImplRepo_Service/LiveCheck.cpp index 87f6317cfe1..6c7867c5654 100644 --- a/TAO/orbsvcs/ImplRepo_Service/LiveCheck.cpp +++ b/TAO/orbsvcs/ImplRepo_Service/LiveCheck.cpp @@ -915,7 +915,7 @@ LiveCheck::remove_server (const char *server, int pid) if (ImR_Locator_i::debug () > 0) { ORBSVCS_DEBUG ((LM_DEBUG, - ACE_TEXT ("(%P|%t) LiveCheck::remove_server removing <%C> pid <%d> entry pid <%d> status <%C>\n "), + ACE_TEXT ("(%P|%t) LiveCheck::remove_server removing <%C> pid <%d> entry pid <%d> status <%C>\n"), server, pid, entry->pid (), LiveEntry::status_name (entry->status ()))); } if (entry_map_.unbind (s, entry) == 0) diff --git a/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.cpp b/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.cpp index 8d781e5a64d..adc92c4336a 100644 --- a/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.cpp +++ b/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.cpp @@ -1,7 +1,6 @@ #include "test_i.h" #include "ace/OS_NS_time.h" - // Implementation skeleton constructor Test_Dummy_i::Test_Dummy_i (void) { @@ -12,9 +11,7 @@ Test_Dummy_i::~Test_Dummy_i (void) { } -char * Test_Dummy_i::getMessage ( - void - ) +char * Test_Dummy_i::getMessage (void) { // Add your implementation here return CORBA::string_dup("Test::Dummy---->Hello World"); @@ -29,22 +26,17 @@ Test_Time_i::~Test_Time_i (void) { } -::CORBA::Long Test_Time_i::current_time ( - void - ) +::CORBA::Long Test_Time_i::current_time (void) { ACE_DEBUG ((LM_DEBUG, "(%P|%t)Test_Time_i::current_time called\n")); return CORBA::Long (ACE_OS::time (0)); } -void Test_Time_i::shutdown ( - void - ) +void Test_Time_i::shutdown (void) { ACE_DEBUG ((LM_DEBUG, "%s\n", "Time_i is shutting down")); - } diff --git a/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.h b/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.h index 3b77ade88cc..53cef409396 100644 --- a/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.h +++ b/TAO/orbsvcs/tests/ImplRepo/RestartIMR/test_i.h @@ -31,15 +31,9 @@ public: // Destructor virtual ~Test_Time_i (void); - virtual - ::CORBA::Long current_time ( - void - ); - - virtual - void shutdown ( - void - ); + virtual ::CORBA::Long current_time (void); + + virtual void shutdown (void); }; diff --git a/TAO/orbsvcs/tests/ImplRepo/RestartServer/README b/TAO/orbsvcs/tests/ImplRepo/RestartServer/README index e324f8ef8a7..999b2bb56df 100644 --- a/TAO/orbsvcs/tests/ImplRepo/RestartServer/README +++ b/TAO/orbsvcs/tests/ImplRepo/RestartServer/README @@ -1,5 +1,3 @@ - - This test verifies that if a server launched by the ImR activator is terminated, then it will be relaunched transparently by the ORB if the client makes another request if -ORBForwardOnTransientLimit and -ORBForwardOnReplyClosedLimit options diff --git a/TAO/orbsvcs/tests/ImplRepo/kill_server/README b/TAO/orbsvcs/tests/ImplRepo/kill_server/README index 0390eb5cd8a..834c10e14c2 100644 --- a/TAO/orbsvcs/tests/ImplRepo/kill_server/README +++ b/TAO/orbsvcs/tests/ImplRepo/kill_server/README @@ -1,5 +1,3 @@ - - This test starts up servers then uses the tao_imr kill command to force server termination via signal. diff --git a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/README b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/README index 0bcf58a4ba8..996416bec09 100644 --- a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/README +++ b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/README @@ -1,5 +1,3 @@ - - This test verifies the ImplRepo service can tolerate servers that are slow to start. In some cases a server may have dependencies to resolve after creating its POAs but before activating them. During this time the server is unable to @@ -7,7 +5,7 @@ respond to shutdown requests, and a kill is required. This test ensures that following the failed shutdown and subsequent kill, the server can be restarted. The server instances append their pid to a status file, which the run script -interogates for judging success. +interrogates for judging success. Runtime options are -debug to turn on verbose debugging to separate log files and -no_dns, which forces the use of 127.0.0.1 in endpoints for running in diff --git a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test.idl b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test.idl index 8a71f966081..2a333b4a6e5 100644 --- a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test.idl +++ b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test.idl @@ -1,7 +1,5 @@ interface Test { - short get_server_num (); oneway void terminate (); - }; diff --git a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test_i.h b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test_i.h index 4fe622f87c7..984bc38669f 100644 --- a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test_i.h +++ b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/Test_i.h @@ -12,12 +12,9 @@ class Test_i : public virtual POA_Test { public: - virtual CORBA::Short get_server_num (void); virtual void terminate (void); - -private: }; #endif /* TEST_I_H_ */ diff --git a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/client.cpp b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/client.cpp index 34668b48a26..7feb962aa13 100644 --- a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/client.cpp +++ b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/client.cpp @@ -3,7 +3,6 @@ #include "ace/Get_Opt.h" #include "ace/OS_NS_unistd.h" - bool killit = false; int diff --git a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/server.cpp b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/server.cpp index 8c43ec1ef9d..293ae2579d8 100644 --- a/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/server.cpp +++ b/TAO/orbsvcs/tests/ImplRepo/kill_slow_server/server.cpp @@ -46,7 +46,7 @@ createPOAs(ACE_CString &base) PortableServer::POAManager_var mgr = PortableServer::POAManager::_nil(); ACE_CString poa_name = base + ACE_CString ("_a"); - ACE_DEBUG ((LM_DEBUG, "%P server creating POA %s\n", poa_name.c_str())); + ACE_DEBUG ((LM_DEBUG, "%P server creating POA %C\n", poa_name.c_str())); poa_a = root_poa->create_POA(poa_name.c_str(), mgr.in(), pols); } @@ -114,7 +114,7 @@ ACE_TMAIN (int argc, ACE_TCHAR *argv[]) ofstream out(status_file.c_str (), ios_base::app); if (!out.good()) { - ACE_DEBUG ((LM_DEBUG, "server did not get good bit from %s\n", status_file.c_str())); + ACE_DEBUG ((LM_DEBUG, "server did not get good bit from %C\n", status_file.c_str())); } out << ACE_OS::getpid () << endl; out.close (); @@ -136,7 +136,7 @@ ACE_TMAIN (int argc, ACE_TCHAR *argv[]) test_ior = orb->object_to_string (tva.in()); base += "_a"; - ACE_DEBUG ((LM_DEBUG, "%s:\n%s\n", base.c_str(), test_ior.in())); + ACE_DEBUG ((LM_DEBUG, "%C:\n%C\n", base.c_str(), test_ior.in())); table->bind (base.c_str (), test_ior.in ()); runner->wait (); diff --git a/TAO/orbsvcs/tests/ImplRepo/ping_interrupt/README b/TAO/orbsvcs/tests/ImplRepo/ping_interrupt/README index 764020f184b..5db1a2a08b1 100644 --- a/TAO/orbsvcs/tests/ImplRepo/ping_interrupt/README +++ b/TAO/orbsvcs/tests/ImplRepo/ping_interrupt/README @@ -1,5 +1,3 @@ - - This test runs checks the behavior of the IMR when a server shuts down while it is in the middle of handling a ping request from the ImR Locator. This scenario could happen in an MT server, although to avoid |