summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Print errno when tbdiff-deploy fails to open streambaserock/benbrewer/post-overhaul-v2Ben Brewer2014-06-041-1/+3
|
* Print usage in tbdiff-deploy when it's used incorrectlyBen Brewer2014-06-041-1/+8
|
* Remove tbd_stat_print since it's unused and unimplementedBen Brewer2014-06-042-7/+0
|
* Use POSIX file operations internally in tbdiff-applyBen Brewer2014-06-041-29/+28
| | | | | | For consistency reasons and because the POSIX functions are more consistent and simple, this also allows us to set the mode on file creation and detect if a file already exists.
* Use POSIX file operations for tbdiff-applyBen Brewer2014-06-045-110/+126
| | | | For the consistency reasons listed in earlier commits.
* Remove tbd_stat_fopen since it's no longer usedBen Brewer2014-06-042-13/+0
| | | | | Since we now use POSIX file functions only in tbdiff-create, we no longer need tbd_stat_fopen, so it's been removed.
* Use POSIX file operations internally in tbdiff-createBen Brewer2014-06-041-41/+35
| | | | | | | | This keeps the code consistent by using the same file functions internally as are used when reading from or writing to the stream. The code is also simplified somewhat since POSIX file operations are cleaner and more consistent than stdio.
* Use POSIX file functions for tbdiff-create streamBen Brewer2014-06-045-79/+88
| | | | | | | POSIX file functions are more consistent and simple, originally stdio was used to make the code as portable as possible, however since it now relies on POSIX functionality anyway there's no need for the inconsistency.
* Use quoted includes for local headers in tbdiff source filesBen Brewer2014-06-025-12/+12
| | | | | | | | | Quoted includes should be used when including headers which represent declarations in local source files. The source files have been modified to reflect this. This makes it more clear which headers are system headers and which are part of the tbdiff codebase.
* Remove use of typedef to avoid naming conflicts with POSIXBen Brewer2014-06-028-138/+142
| | | | | | | | | | | | POSIX reserves the use of the underscore T postfix for types, since most of the time we don't actually need to typedef the types and since it's more clear to prefix structs and enums with the struct and enum keywords, I've removed all uses of typedef and gone with the more simple approach used in the kernel. One typedef remains which is tbd_cmd_type, since this should be a native type of a fixed size. The postfix changed to type to show that it's a type and to ensure it doesn't collide with POSIX.
* Remove extern keyword since it's not neededBen Brewer2014-06-024-32/+32
| | | | | | The extern keyword is not needed since it's the default property for a function, it also takes up extra space on the line which leads to more wrapping.
* Merge branch 'baserock/benbrewer/overhaul-v2'Ben Brewer2014-06-0211-455/+519
|\ | | | | | | | | Reviewed-by: Richard Maw Reviewed-by: Lars Wirzenius
| * Print warning using TBD_WARN when chown failsbaserock/benbrewer/overhaul-v2Ben Brewer2014-06-021-8/+17
| | | | | | | | | | | | The compiler currently warns that the result of chown is ignored, for now we'll print a warning when the chown operation fails, but it'll need to be handled as an error eventually.
| * Use TBD_DEBUG macro to print the value of an invalid commandBen Brewer2014-06-021-1/+1
| | | | | | | | | | Use the TBD_DEBUG macro since it will be disabled when debug is disabled, otherwise we'd always print the error message.
| * Use TBD_DEBUG macro instead of fprint for debug messagesBen Brewer2014-06-022-21/+21
| | | | | | | | | | We now use the TBD_DEBUG macro rather than fprintf, this means that debug messages aren't printed when debugging is disabled.
| * Added warning and debug mechanism to tbdiff-common.hBen Brewer2014-06-021-2/+29
| | | | | | | | | | | | | | Added TBD_WARN and TBD_DEBUG macros to allow for warnings and debug messages to be printed. This will make current debugging messages cleaner and allow us to warn when the chown operation fails.
| * Cleanup writing of xattr pairs in tbdiff-create.cBen Brewer2014-06-021-11/+14
| |
| * style: Rename fread/fwrite in function names to read and writeBen Brewer2014-06-022-86/+86
| | | | | | | | | | | | | | | | The implementation currently uses fread and fwrite which are specific functions in stdlib, however this is an implementation detail and in the future these functions may not be used, so it doesn't make sense to name the higher level functions based on the function they use underneath.
| * Remove read/write_size from tbdiff-io since they're unusedBen Brewer2014-06-022-14/+0
| | | | | | | | | | Also removed because size_t can vary in size across platforms, which makes it unsuitable for storing in our diff stream.
| * style: Cleanup the names of the tbd read/write wrappersBen Brewer2014-06-024-90/+90
| |
| * Add externs to functions in tbdiff-io.h and cleanupBen Brewer2014-06-021-32/+18
| | | | | | | | | | The externs are not required but it's inkeeping with the other headers which all currently have them.
| * Simplify endian swapping in tbdiff-io.cBen Brewer2014-06-021-65/+51
| | | | | | | | | | | | | | | | Simplify the endian swapping by always calling the endian macro and only implementing it when the platform is big-endain. The endian swapping function has also been made a little more obvious and now uses a byteswap inline function to swap the bytes.
| * Make TB_DIFF_PROTOCOL_ID a static const char for type safetyBen Brewer2014-06-021-2/+2
| |
| * Use correct pointer type for parent member in tbd_stat_tBen Brewer2014-06-021-3/+5
| | | | | | | | | | | | | | The parent pointer in tbd_stat_t was void since it pointed to itself, to make the code more clear I've typedef'd the struct above so that the pointer can now point to itself as an incomplete type.
| * Create tbd_cmd_t type to for commands and use sizeof in writeBen Brewer2014-06-023-7/+9
| | | | | | | | | | | | Previously commands were just treated as a uint8_t and given the value of and enum. This is now made more clear in the code by defining tbd_cmd_t as a uint8_t below the enum in tbdiff-common.h.
| * style: Fix whitespace in tbdiff-common.hBen Brewer2014-06-021-27/+27
| |
| * style: Fix alignment and func defs in tbdiff-apply.cBen Brewer2014-06-021-29/+34
| |
| * style: Fix alignment and whitespace issues in tbdiff-createBen Brewer2014-06-021-59/+61
| |
| * style: Fix indentation and whitespace in tbdiff-io.cBen Brewer2014-06-021-80/+80
| |
| * style: Fix alignment of tbd_stat_t struct membersBen Brewer2014-06-021-3/+3
| |
| * style: Convert all cpp style comments to c style commentsBen Brewer2014-06-024-22/+22
| |
| * Fix fp resource leaks in tbdiff-applyBen Brewer2014-06-021-21/+48
| | | | | | | | | | There were a lot of instances where on error the code would fail to close the opened file pointer.
| * Fix memory leak of name in tbdiff-stat.cBen Brewer2014-06-021-2/+4
| | | | | | | | On error the duplicated string in 'name' would have leaked.
| * Use ENODATA instead of ENOATTRBen Brewer2014-06-021-1/+1
| | | | | | | | | | | | The man page for lsetxattr says that ENOATTR is a synonym of ENODATA, since ENOATTR is not always available in sys/xattr.h we'll use ENODATA instead.
| * Use sys/xattr from libc if attr/xattr is unavailableBen Brewer2014-06-022-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | On my system tbdiff failed to build because attr/xattr doesn't exist, also the attr package was not easy to find. On searching I discovered that the functionality we use in attr.h is provided by modern versions of libc, as shown here: https://bugzilla.kernel.org/show_bug.cgi?id=70141 This patch falls back to using libc sys/xattr.h when attr/xattr.h is unavailable.
| * Update gitignore file to ignore autotools generated filesBen Brewer2014-06-021-0/+28
| |
| * documentation: Remove issues which have already been resolvedBen Brewer2014-06-021-14/+0
|/ | | | | Some issues in the TODO file have been resolved and no longer apply, these issues have been removed.
* Merge branch 'baserock/pedroalvarez/trove-upgrades-rebase2'Pedro Alvarez2014-03-067-15/+378
|\ | | | | | | | | | | Reviewed-by: Richard Maw Reviewed-by: Lars Wirzenius Reviewed-by: Sam Thursfield
| * system-version-manager: Allow specifying custom path for ↵baserock/pedroalvarez/trove-upgrades-rebase2Sam Thursfield2014-03-061-1/+5
| | | | | | | | | | | | | | baserock-system-config-sync This is helpful when deploying an upgrade to a system that doesn't already have baserock-system-config-sync installed.
| * Add script to modify the bootloader and manage different parallel OS.Pedro Alvarez2014-03-064-2/+338
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is part of the upgrades work. With this tool you can now switch between versions of the OS, remove a version, list all the versions present in the system, get the default version and the running version, and deploy a new system. All of the above is possible with the following subcommands: - list - deploy - get-default - get-running - remove - set-default It also activates a bootloader menu to choose a version to boot. The menu is important to make sure the user can boot the old OS if the new kernel doesn't work.
| * baserock-system-config-sync: Force copy /etc/passwd and /etc/groupPedro Alvarez2014-03-061-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change is to ensure the existing users will exist after an upgrade. Otherwise, if there are merge conflicts when upgrading, the users will be lost and the root password will be deactivated. If that happens and the only way to access to the system is through ssh and the system was rebooted after the upgrade (manually or automatically) then the system won't be accessible anymore. This change also means that we can no longer make changes to the base /etc/passwd or /etc/group in the 'fhs-dirs' chunk without adding a manual hook to add the new users/groups when upgrading old systems. In the following link is the email thread where was discussed this issue: http://vlists.pepperfish.net/pipermail/baserock-dev-baserock.org/2014-March/004581.html
| * baserock-system-config-sync: Add some logging to the standard output.Pedro Alvarez2014-03-061-0/+15
| |
| * Modify 'baserock-system-config-sync' to get two arguments using 'merge'Pedro Alvarez2014-03-062-7/+8
| | | | | | | | | | | | | | Since with 'system-version-manager' is possible to change the default system, 'baserock-system-config-sync' shouldn't get the default system, and get an extra parameter to choose the system version to merge.
| * Fix error in the baserock-system-config-sync behaviour table.Pedro Alvarez2014-03-051-2/+2
| | | | | | | | | | | | | | When one file is present in v1 and in vUser, and is not present in v2, baserock-system-config-sync copies vUser version of the file. This was happening before this commit, but it was wrong explained in the behaviour table.
| * Fix behaviour in bscs-merge when vUser and v2 don't have a file of v1Pedro Alvarez2014-03-052-4/+3
|/ | | | | If a file was removed in vUser, and v2 doesn't have a new one, then the file is not longer needed.
* Merge branch 'baserock/pedroalvarez/bscs-wrong-merge2'Pedro Alvarez2014-02-2610-11/+33
|\ | | | | | | Reviewed-by: Richard Maw
| * Prevent patching when 'vu == v2' in 'baserock-system-config-sync'.Pedro Alvarez2014-02-261-6/+15
| | | | | | | | | | | | | | When vu == v2, the script tried to reverse the patch. Now this won't happen again. Also added '-f' flag calling 'patch' to prevent also reverse patching.
| * Fix baserock-system-config-sync tests. Wasn't working as expected.Pedro Alvarez2014-02-261-5/+2
| |
| * Add test case for vu == v2 in 'baserock-system-config-sync'Pedro Alvarez2014-02-248-0/+16
|/ | | | | 'baserock-system-config-sync' is doing reverse patching when that happens. This test is to check the expected behaviour.
* Merge branch 'baserock/pedroalvarez/bscs-upgrade-tests3'Pedro Alvarez2014-02-203-4/+38
|\ | | | | | | | | Reviewed-by: Richard Maw Reviewed-by: Sam Thursfield
View Lorry Controller Status