From dea5d6f8cbd86916ec5373fb704c67e1a33e29a8 Mon Sep 17 00:00:00 2001 From: Richard Maw Date: Mon, 16 Sep 2013 14:52:01 +0000 Subject: foreach: sort repositories asciibetically The test suite checks the output of the foreach command, this requires repositories to be returned in a stable order. The order returned from os.listdir differs by the filesystem used. btrfs returns roughly in insertion order, tmpfs alphabetically. This allowed the failure to sort pass through unchecked, since I was testing on btrfs, but people discovered issues when using /tmp, which is a tmpfs. To fix this, foreach sorts the result of list_git_directories() by directory name. The previous code would always return the root repository first, this was a unnecessary complication, so now everything is returned asciibetically and the tests amended to reflect this. --- tests.branching/foreach-handles-command-failure.stderr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests.branching/foreach-handles-command-failure.stderr') diff --git a/tests.branching/foreach-handles-command-failure.stderr b/tests.branching/foreach-handles-command-failure.stderr index c3085343..c7b8316b 100644 --- a/tests.branching/foreach-handles-command-failure.stderr +++ b/tests.branching/foreach-handles-command-failure.stderr @@ -1 +1 @@ -ERROR: Command failed at repo test:morphs: git remote update non-existant-remote +ERROR: Command failed at repo test:hello: git remote update non-existant-remote -- cgit v1.2.1