From 9ff939ae35944a4c4a2fa0af972ce22c702a3cab Mon Sep 17 00:00:00 2001 From: Sam Thursfield Date: Thu, 2 Apr 2015 16:21:54 +0100 Subject: distbuild: Disable extra message debugging in worker log files Worker log files are overly verbose with this enabled, each message is dumped 6 times: 2015-03-19 11:00:11 DEBUG JsonMachine: Received: '"{...}\\n"\n' 2015-03-19 11:00:11 DEBUG JsonMachine: line: '"{...}\\n"' 2015-03-19 11:00:11 DEBUG JsonRouter: got msg: {...} 2015-03-19 11:00:11 DEBUG JsonMachine: Sending message {...} 2015-03-19 11:00:11 DEBUG JsonMachine: As '"{...}\\n"' 2015-03-19 11:00:11 DEBUG JsonRouter: sent to client: {...} With this setting disabled, the message is only logged by the JsonRouter class, so appears only twice: 2015-03-19 11:00:11 DEBUG JsonRouter: got msg: {...} 2015-03-19 11:00:11 DEBUG JsonRouter: sent to client: {...} We've not seen any issues with message encoding/decoding recently so I think it's safe to disable this debugging output by default. Change-Id: I7d22ed29e81d6c594cb2c639abf3b40bfb27e3ad --- distbuild/json_router.py | 1 - 1 file changed, 1 deletion(-) diff --git a/distbuild/json_router.py b/distbuild/json_router.py index b8d0ca55..d9c32a9c 100644 --- a/distbuild/json_router.py +++ b/distbuild/json_router.py @@ -47,7 +47,6 @@ class JsonRouter(distbuild.StateMachine): def setup(self): jm = distbuild.JsonMachine(self.conn) - jm.debug_json = True self.mainloop.add_state_machine(jm) spec = [ -- cgit v1.2.1