From 8f72c7397f9b62046291d1d699f04ae0233e1afe Mon Sep 17 00:00:00 2001 From: Richard Ipsum Date: Tue, 25 Feb 2014 16:53:35 +0000 Subject: Fix push_build_branches A semantic error in the BuildBranch class meant that it was not possible to push temporary branches. This escaped testing since BuildBranch interacts too tightly with other components to be easily unit-tested, so testing was deferred to a yarn test. However, coverage isn't measured in yarn tests, so this code path was forgotten. --- morphlib/buildbranch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/morphlib/buildbranch.py b/morphlib/buildbranch.py index 546a29d5..d415e7e1 100644 --- a/morphlib/buildbranch.py +++ b/morphlib/buildbranch.py @@ -217,7 +217,7 @@ class BuildBranch(object): # current HEAD if self._push_temporary: with morphlib.branchmanager.RemoteRefManager(False) as rrm: - for gd, build_ref in self._to_push.iterkeys(): + for gd, (build_ref, index) in self._to_push.iteritems(): remote = gd.get_remote('origin') yield gd, build_ref, remote refspec = morphlib.gitdir.RefSpec(build_ref) -- cgit v1.2.1