From 5d10e7584ce134998766223d371d3ee22ad9d017 Mon Sep 17 00:00:00 2001 From: Lars Wirzenius Date: Tue, 22 Apr 2014 14:14:23 +0000 Subject: Add a FIXME comment about losing output while killing --- lorry-controller-minion | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'lorry-controller-minion') diff --git a/lorry-controller-minion b/lorry-controller-minion index fe2089f..c269645 100755 --- a/lorry-controller-minion +++ b/lorry-controller-minion @@ -134,6 +134,12 @@ class MINION(cliapp.Application): if exit is not None: break if kill_job: + # FIXME: The job may have produced more output while + # we were talking to WEBAPP. We are not polling the + # process again, here. This should be fixed. However, + # since the process may be in an unkillable state (D + # state, for example), we also can't wait here until + # it actually dies. Thus, this needs thinking. exit = self.kill_job() self.update_webapp_about_job( job_spec, '', '', exit) -- cgit v1.2.1