From f48239c213b2cd67ced9be50ff2ac18ab288b89f Mon Sep 17 00:00:00 2001
From: Pedro Alvarez <pedro.alvarez@softiron.com>
Date: Tue, 17 May 2022 11:23:58 +0100
Subject: Stop supybot before copying

Supybot will write to file the in-memory configuration befor stopping
overriding the configuration changes we install.

Stopping the service first is a workaround to avoid this situation.
---
 baserock_webserver/instance-irclogs-config.yml | 45 ++++++++++++++++++++------
 1 file changed, 36 insertions(+), 9 deletions(-)

diff --git a/baserock_webserver/instance-irclogs-config.yml b/baserock_webserver/instance-irclogs-config.yml
index 6efb14cf..5690971c 100644
--- a/baserock_webserver/instance-irclogs-config.yml
+++ b/baserock_webserver/instance-irclogs-config.yml
@@ -32,15 +32,6 @@
     become: yes
     become_user: root
 
-  - name: supybot configuration
-    template:
-      src: "irclogs/supybot-baserock.conf"
-      dest: "/home/supybot/supybot-baserock.conf"
-      owner: supybot
-      group: supybot
-    become: yes
-    become_user: root
-
   - name: install systemd units
     copy:
       src: ./irclogs/{{item}}
@@ -52,6 +43,35 @@
       - irclogs-generation.timer
       - supybot.service
 
+  - name: check if there are supybot configuration changes
+    template:
+      src: "irclogs/supybot-baserock.conf"
+      dest: "/home/supybot/supybot-baserock.conf"
+      owner: supybot
+      group: supybot
+    become: yes
+    become_user: root
+    check_mode: yes
+    register: supybot_config
+
+  - name: update supybot configuration
+    block:
+      - name: stop supybot
+        service:
+          name: supybot
+          state: stopped
+        notify: start supybot
+
+      - name: supybot configuration
+        template:
+          src: "irclogs/supybot-baserock.conf"
+          dest: "/home/supybot/supybot-baserock.conf"
+          owner: supybot
+          group: supybot
+    become: yes
+    become_user: root
+    when: supybot_config.changed
+
   - name: enable systemd units
     systemd:
       name: "{{item}}"
@@ -64,3 +84,10 @@
       - irclogs-generation.service
       - irclogs-generation.timer
       - supybot.service
+
+  handlers:
+    - name: start supybot
+      service:
+        name: supybot
+        state: started
+      become: yes
-- 
cgit v1.2.1