diff options
| author | Tiago Gomes <tiago.gomes@codethink.co.uk> | 2015-04-28 12:59:30 +0000 |
|---|---|---|
| committer | Pedro Alvarez <pedro.alvarez@codethink.co.uk> | 2015-05-01 12:22:38 +0000 |
| commit | 238cc03efc245e3ced3aca4c7280385365e1ac6d (patch) | |
| tree | 6ae74291e389c45617da906132f5c2cc608c5f6b | |
| parent | e015a8314483fdbf67665c304dcb83c661fdd169 (diff) | |
| download | definitions-238cc03efc245e3ced3aca4c7280385365e1ac6d.tar.gz | |
openstack: improve cinder configuration extension
Change-Id: I709085e7ca489510196cb6ea8c0502cdd34ff3a0
| -rw-r--r-- | openstack-cinder.configure | 64 |
1 files changed, 26 insertions, 38 deletions
diff --git a/openstack-cinder.configure b/openstack-cinder.configure index 1eeb25bd..4c32e11a 100644 --- a/openstack-cinder.configure +++ b/openstack-cinder.configure @@ -23,44 +23,6 @@ enable(){ "$ROOT/etc/systemd/system/multi-user.target.wants/$1.service" } -########################################################################## -# Check variables -########################################################################## - -if [ -z "$RABBITMQ_HOST" -a \ - -z "$RABBITMQ_PORT" -a \ - -z "$RABBITMQ_USER" -a \ - -z "$RABBITMQ_PASSWORD" -a \ - -z "$KEYSTONE_TEMPORARY_ADMIN_TOKEN" -a \ - -z "$CINDER_DB_USER" -a \ - -z "$CINDER_DB_PASSWORD" -a \ - -z "$CONTROLLER_HOST_ADDRESS" -a \ - -z "$CINDER_SERVICE_USER" -a \ - -z "$CINDER_SERVICE_PASSWORD" -a \ - -z "$CINDER_DEVICE" -a \ - -z "$MANAGEMENT_INTERFACE_IP_ADDRESS" ]; then - # No Cinder options defined, do nothing. - exit 0 -fi - -if [ -z "$RABBITMQ_HOST" -o \ - -z "$RABBITMQ_PORT" -o \ - -z "$RABBITMQ_USER" -o \ - -z "$RABBITMQ_PASSWORD" -o \ - -z "$KEYSTONE_TEMPORARY_ADMIN_TOKEN" -o \ - -z "$CINDER_DB_USER" -o \ - -z "$CINDER_DB_PASSWORD" -o \ - -z "$CONTROLLER_HOST_ADDRESS" -o \ - -z "$CINDER_SERVICE_USER" -o \ - -z "$CINDER_SERVICE_PASSWORD" -o \ - -z "$CINDER_DEVICE" -o \ - -z "$MANAGEMENT_INTERFACE_IP_ADDRESS" ]; then - echo Some options required for Cinder were defined, but not all. - exit 1 -fi - -# Check optional variables - unnaceptable(){ eval echo Unexpected value \$$1 for $1 >&2 exit 1 @@ -80,10 +42,36 @@ check_bool(){ esac } +########################################################################## +# Check variables +########################################################################## + check_bool CINDER_ENABLE_CONTROLLER check_bool CINDER_ENABLE_COMPUTE check_bool CINDER_ENABLE_STORAGE +if ! "$CINDER_ENABLE_CONTROLLER" && \ + ! "$CINDER_ENABLE_COMPUTE" && \ + ! "$CINDER_ENABLE_STORAGE"; then + exit 0 +fi + +if [ -z "$RABBITMQ_HOST" -o \ + -z "$RABBITMQ_PORT" -o \ + -z "$RABBITMQ_USER" -o \ + -z "$RABBITMQ_PASSWORD" -o \ + -z "$KEYSTONE_TEMPORARY_ADMIN_TOKEN" -o \ + -z "$CINDER_DB_USER" -o \ + -z "$CINDER_DB_PASSWORD" -o \ + -z "$CONTROLLER_HOST_ADDRESS" -o \ + -z "$CINDER_SERVICE_USER" -o \ + -z "$CINDER_SERVICE_PASSWORD" -o \ + -z "$CINDER_DEVICE" -o \ + -z "$MANAGEMENT_INTERFACE_IP_ADDRESS" ]; then + echo Some options required for Cinder were defined, but not all. + exit 1 +fi + ###################################### # Enable relevant openstack services # ###################################### |